Bug 249968 - timidity++: $RPM_OPT_FLAGS not used, useless debuginfo package
Summary: timidity++: $RPM_OPT_FLAGS not used, useless debuginfo package
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: timidity++
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-07-28 17:51 UTC by Ville Skyttä
Modified: 2007-11-30 22:12 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-10-14 19:41:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Use $RPM_OPT_FLAGS, fix -debuginfo (747 bytes, patch)
2007-07-28 17:51 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2007-07-28 17:51:25 UTC
timidity++ is built without $RPM_OPT_FLAGS, and its debuginfo package is
practically useless.

Fix attached, more info: http://fedoraproject.org/wiki/Packaging/Debuginfo

The fix also moves autoconf to %prep, IMO it's a more suitable place for it than
%build, and configures with --disable-dependency-tracking for cleaner build
output and possible small build speedup.

Comment 1 Ville Skyttä 2007-07-28 17:51:25 UTC
Created attachment 160170 [details]
Use $RPM_OPT_FLAGS, fix -debuginfo

Comment 2 Jindrich Novy 2007-10-12 14:32:35 UTC
Fixed, thanks.

Comment 3 Ville Skyttä 2007-10-12 14:52:28 UTC
Hm, 2.13.2-3 no longer explicitly runs autoconf at all, was that intentional? 
BuildRequires: autoconf is still there.

Comment 4 Ville Skyttä 2007-10-12 14:53:10 UTC
(Jindrich, see comment 3)

Comment 5 Jindrich Novy 2007-10-12 16:18:01 UTC
Ville, yes, it was intentional. It seems to work just fine without autoconf as
the configure script is sane. I forgot to remove the autoconf BR. Hans wants to
fix other bugs in timidity so I let addition or removal of the autoconf upon his
decision. He can do it altogether with other fixes in the next build.

Comment 6 Hans de Goede 2007-10-13 07:27:47 UTC
Note: fixed in CVS, not building yet as I also want to fix bug 200688 before
building.


Comment 7 Hans de Goede 2007-10-14 19:41:25 UTC
I've just started a build for 2.13.2-4, which fixes this, closing.



Note You need to log in before you can comment on or make changes to this bug.