Bug 2501792

Summary:	Review Request: perl-Encoding-FixLatin - Takes mixed encoding input and produces UTF-8 output
Product:	[Fedora] Fedora	Reporter:	Xavier Bachelot <xavier>
Component:	Package Review	Assignee:	Emmanuel Seyman <emmanuel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	emmanuel, package-review
Target Milestone:	---	Flags:	emmanuel: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2026-10-02 16:28:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2501793

Description Xavier Bachelot 2026-07-17 16:39:55 UTC

Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Encoding-FixLatin.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Encoding-FixLatin-1.04-1.fc45.src.rpm
Description:
Most encoding conversion tools take input in one encoding and produce
output in another encoding. This module takes input which may contain
characters in more than one encoding and makes a best effort to convert
them all to UTF-8 output.
Fedora Account System Username: xavierb

Comment 1 Emmanuel Seyman 2026-09-08 22:02:26 UTC

Taking.

Comment 2 Emmanuel Seyman 2026-09-08 23:30:25 UTC

URL and Source0 are ok
Source0 archive (SHA-512:7091e503b11c9d1c5a3dd38156467cf398ae4b96e1c109db4781478dfb100c2cc50e688c742392f66b9f195b936c19cafe003fffe4fc0459165b02622c154f72) is original. Ok.
License verified from Encoding/FixLatin.pm is ok.
Summary is ok.
Description is ok

BuildRequires are ok
FIX: Add build-require 'coreutils' - it is needed for %{_fixperms}
TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76
      NO_PACKLIST is provided since this version.

$ rpm -qp --requires perl-Encoding-FixLatin* | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Encode)
      1 perl(Encoding::FixLatin)
      1 perl(Exporter)
      1 perl(Getopt::Long)
      1 perl-libs
      1 perl(Pod::Usage)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-Encoding-FixLatin* | sort | uniq -c

Binary provides are Ok.

$ rpmlint output: 0 errors, 0 warnings, 4 filtered, 0 badness

The package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' item and consider fixing 'TODO' items.

Resolution:
Approved

Comment 3 Fedora Admin user for bugzilla script actions 2026-09-09 15:16:46 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Encoding-FixLatin
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 4 Xavier Bachelot 2026-09-09 15:23:24 UTC

Thanks for the review Emmanuel !
Both issue fixed as well as some trailing white spaces.