Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Encoding-FixLatin.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Encoding-FixLatin-1.04-1.fc45.src.rpm Description: Most encoding conversion tools take input in one encoding and produce output in another encoding. This module takes input which may contain characters in more than one encoding and makes a best effort to convert them all to UTF-8 output. Fedora Account System Username: xavierb
Taking.
URL and Source0 are ok Source0 archive (SHA-512:7091e503b11c9d1c5a3dd38156467cf398ae4b96e1c109db4781478dfb100c2cc50e688c742392f66b9f195b936c19cafe003fffe4fc0459165b02622c154f72) is original. Ok. License verified from Encoding/FixLatin.pm is ok. Summary is ok. Description is ok BuildRequires are ok FIX: Add build-require 'coreutils' - it is needed for %{_fixperms} TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Encoding-FixLatin* | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(Encode) 1 perl(Encoding::FixLatin) 1 perl(Exporter) 1 perl(Getopt::Long) 1 perl-libs 1 perl(Pod::Usage) 1 perl(strict) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) 1 /usr/bin/perl Binary requires are Ok. $ rpm -qp --provides perl-Encoding-FixLatin* | sort | uniq -c Binary provides are Ok. $ rpmlint output: 0 errors, 0 warnings, 4 filtered, 0 badness The package is in line with Fedora and Perl packaging guide lines. Please correct 'FIX' item and consider fixing 'TODO' items. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Encoding-FixLatin Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Thanks for the review Emmanuel ! Both issue fixed as well as some trailing white spaces.