Bug 250467
Summary: | Review Request: rainbow - The service component of the OLPC Bitfrost security platform | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Noah Kantrowitz <noah> |
Component: | Package Review | Assignee: | Brian Pepple <bdpepple> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, kevin, notting |
Target Milestone: | --- | Flags: | bdpepple:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-08-13 23:48:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Noah Kantrowitz
2007-08-01 19:19:29 UTC
MD5Sums: 9a2c828bf6b91aa2f343fc88b3ab2eab rainbow-20070731gitde262e.tar.bz2 Good: * Source URL is canonical * git source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All directories are owned by this or other packages * All necessary BuildRequires listed. * Package build fine in Mock Bad: * rpmlint produces the following error, which should be easy to fix: E: rainbow non-standard-executable-perm /usr/sbin/rainbow 0744 E: rainbow non-readable /etc/rainbow/rainbow.conf 0600 * You should use a macro for '/usr/sbin/rainbow'. refer to http://fedoraproject.org/wiki/Packaging/RPMMacros * Does the package really need python-setuptools as a Require? Minor: * you can drop the sitearch variable from the spec, since it's unused. * you can remove the CFLAGS from the build call, since it's a noarch package. +1 approved, please review and fix the bad items before importing into CVS. thanks. New Package CVS Request ======================= Package Name: rainbow Short Description: The service component of the OLPC Bitfrost security platform Owners: coderanger Branches: OLPC-2 InitialCC: coderanger, Commits by cvsextras: no I don't see a 'coderanger' user in the account system. Can you check that and resubmit by resetting the fedora-cvs flag? Perhaps should be 'kantrn' ? New Package CVS Request ======================= Package Name: rainbow Short Description: The service component of the OLPC Bitfrost security platform Owners: kantrn Branches: OLPC-2 InitialCC: kantrn Commits by cvsextras: no cvs done. |