Spec URL: http://dev.laptop.org/~coderanger/rpm/rainbow/rainbow.spec SRPM URL: http://dev.laptop.org/~coderanger/rpm/rainbow/rainbow-1.0-0.0.20070731gitde262e.src.rpm Description: This is the security service as described in the OLPC Bitfrost platform (http://wiki.laptop.org/go/OLPC_Bitfrost). This package is reasonably specific to OLPC environment (though it would work on a standard desktop with VServer installed).
MD5Sums: 9a2c828bf6b91aa2f343fc88b3ab2eab rainbow-20070731gitde262e.tar.bz2 Good: * Source URL is canonical * git source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All directories are owned by this or other packages * All necessary BuildRequires listed. * Package build fine in Mock Bad: * rpmlint produces the following error, which should be easy to fix: E: rainbow non-standard-executable-perm /usr/sbin/rainbow 0744 E: rainbow non-readable /etc/rainbow/rainbow.conf 0600 * You should use a macro for '/usr/sbin/rainbow'. refer to http://fedoraproject.org/wiki/Packaging/RPMMacros * Does the package really need python-setuptools as a Require? Minor: * you can drop the sitearch variable from the spec, since it's unused. * you can remove the CFLAGS from the build call, since it's a noarch package. +1 approved, please review and fix the bad items before importing into CVS. thanks.
New Package CVS Request ======================= Package Name: rainbow Short Description: The service component of the OLPC Bitfrost security platform Owners: coderanger Branches: OLPC-2 InitialCC: coderanger, Commits by cvsextras: no
I don't see a 'coderanger' user in the account system. Can you check that and resubmit by resetting the fedora-cvs flag? Perhaps should be 'kantrn' ?
New Package CVS Request ======================= Package Name: rainbow Short Description: The service component of the OLPC Bitfrost security platform Owners: kantrn Branches: OLPC-2 InitialCC: kantrn Commits by cvsextras: no
cvs done.