Bug 257941

Summary:	Review Request: hedgewars - 2D tankbattle game with the tanks replaced by hedgehogs
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	Package Review	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bojanpopovic, fedora-package-review, haskell-devel, notting
Target Milestone:	---	Flags:	gauret: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-09-10 11:20:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hans de Goede 2007-08-27 20:18:30 UTC

Spec URL: http://people.atrpms.net/~hdegoede/hedgewars.spec
SRPM URL: http://people.atrpms.net/~hdegoede/hedgewars-0.9.0-1.fc8.src.rpm
Description:
Hedgewars is a turn based strategy game but the real buzz is from watching the
devastation caused by those pesky hedgehogs with those fantastic weapons.

Each player controls a team of several hedgehogs. During the course of the
game, players take turns with one of their hedgehogs. They then use whatever
tools and weapons are available to attack and kill the opponents' hedgehogs,
thereby winning the game. Hedgehogs may move around the terrain in a variety  
of ways, normally by walking and jumping but also by using particular tools
such as the "Rope" or "Parachute", to move to otherwise inaccessible areas.

Comment 1 Aurelien Bompard 2007-09-09 11:37:28 UTC

Review for release 1:
* RPM name is OK
* Source hedgewars-src-0.9.0.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint looks OK

* File list of hedgewars looks strange : data files are in
"/usr/share/hedgewars/hedgewars", isn't that one "hedgewars" too many ?
* The Icon tag in the desktop file should either use the full path or not
include the file's extension
(http://fedoraproject.org/wiki/Packaging/Guidelines#desktop)

Please see to that, otherwise the package looks fine (the game is very similar
to wormux though...)

Comment 2 Hans de Goede 2007-09-09 15:44:02 UTC

(In reply to comment #1)
> * File list of hedgewars looks strange : data files are in
> "/usr/share/hedgewars/hedgewars", isn't that one "hedgewars" too many ?
> * The Icon tag in the desktop file should either use the full path or not
> include the file's extension
> (http://fedoraproject.org/wiki/Packaging/Guidelines#desktop)

Both fixed now:

Spec URL: http://people.atrpms.net/~hdegoede/hedgewars.spec
SRPM URL: http://people.atrpms.net/~hdegoede/hedgewars-0.9.0-2.fc8.src.rpm

Comment 3 Aurelien Bompard 2007-09-09 20:16:47 UTC

Review for release 2.fc7:
* RPM name is OK
* Source hedgewars-src-0.9.0.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Plays fine

APPROVED

Comment 4 Hans de Goede 2007-09-09 21:08:50 UTC

Thanks!

New Package CVS Request
=======================
Package Name:      hedgewars
Short Description: 2D tankbattle game with the tanks replaced by hedgehogs
Owners:            jwrdegoede
Branches:          F-7 devel
InitialCC:         <empty>
Cvsextras Commits: Yes

Comment 5 Kevin Fenzi 2007-09-09 22:43:01 UTC

cvs done.

Comment 6 Hans de Goede 2007-09-10 11:20:26 UTC

Imported and build, closing.

Comment 7 Hans de Goede 2007-10-18 20:09:42 UTC

Package Change Request
======================
Package Name: hedgewars
New Branches: F-8

Thanks!

Comment 8 Kevin Fenzi 2007-10-21 16:22:54 UTC

All packages have now been branched for F-8, so this request should be done. 
Feel free to reset fedora-cvs flag if you need anything futher.

Comment 9 Mamoru TASAKA 2009-04-26 16:10:56 UTC

*** Bug 491521 has been marked as a duplicate of this bug. ***