Bug 266261
| Summary: | Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Akira TAGOH <tagoh> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eng-i18n-bugs, fedora-package-review, notting, opensource, panemade |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-26 11:14:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 253149 | ||
|
Description
Akira TAGOH
2007-08-30 05:51:20 UTC
This package is split up from fonts-japanese. http://fedoraproject.org/wiki/Packaging/Conflicts - Usage of conflicts need to be approved, I asked on fedora packaging list about this: https://www.redhat.com/archives/fedora-packaging/2007-September/msg00010.html - Conflicts should be ok. (see the previously mentioned thread)
- Building with mock gives an error:
+ install -m 0644 -p 'fonts/*.pcf.gz'
/var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/
install: cannot stat `fonts/*.pcf.gz': No such file or directory
this
install -m 0644 -p fonts/*.pcf.gz $RPM_BUILD_ROOT%{fontdir}/
should be changed to
install -m 0644 -p *.pcf.gz $RPM_BUILD_ROOT%{fontdir}/
- this should be removed because it is not used:
%define buildsubdir %{name}-%{version}
- in %prep
instead of
%{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version}
cd $RPM_BUILD_DIR/%{name}-%{version}
tar xfz %{SOURCE0}
this should be used:
%setup -q -n fonts
(In reply to comment #3) > - Building with mock gives an error: > + install -m 0644 -p 'fonts/*.pcf.gz' > /var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/ > install: cannot stat `fonts/*.pcf.gz': No such file or directory Doh. my bad. however: > - in %prep > instead of > %{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version} > cd $RPM_BUILD_DIR/%{name}-%{version} > tar xfz %{SOURCE0} > this should be used: > %setup -q -n fonts I'm worrying about following that since "fonts" is too generic and it might affects to others perhaps. Ok, updated. hopefully it should works enough. Spec URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts.spec SRPM URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts-1.1-2.fc8.src.rpm ? - fonts-japanese spec file contains fonts.cache-1 and encodings.dir.
Are these ghost files no longer needed?
Yes for this package at least, because those ghost are still required for fonts-japanese to ensure removing all the files and the directories cleanly when the package is removed so that it was generated outside the package. and this package uses the different install dir and no longer created. No, it isn't needed anymore, I meant. Then okay for this package. ----------------------------------------------------- This package (knm_new-fonts) is APPROVED by me ----------------------------------------------------- Thanks for quick review. New Package CVS Request ======================= Package Name: knm_new-fonts Short Description: 12x12 JIS X 0208 Bitmap font Owners: tagoh Branches: devel InitialCC: Cvsextras Commits: yes cvs done. |