Bug 266261 - Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font
Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 253149
TreeView+ depends on / blocked
 
Reported: 2007-08-30 05:51 UTC by Akira TAGOH
Modified: 2007-11-30 22:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-09-26 11:14:38 UTC
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Akira TAGOH 2007-08-30 05:51:20 UTC
Spec URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts.spec
SRPM URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts-1.1-1.fc8.src.rpm
Description:
This package provides 12x12 Japanese bitmap font for JIS X 0208.
JIS X 0208 is a character set that contains Kanji characters mostly
often used.

Comment 1 Akira TAGOH 2007-08-30 05:52:46 UTC
This package is split up from fonts-japanese.

Comment 2 Till Maas 2007-09-06 13:08:22 UTC
http://fedoraproject.org/wiki/Packaging/Conflicts - Usage of conflicts need to
be approved, I asked on fedora packaging list about this:
https://www.redhat.com/archives/fedora-packaging/2007-September/msg00010.html

Comment 3 Till Maas 2007-09-06 22:04:02 UTC
- Conflicts should be ok. (see the previously mentioned thread)

- Building with mock gives an error:
+ install -m 0644 -p 'fonts/*.pcf.gz'
/var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/
install: cannot stat `fonts/*.pcf.gz': No such file or directory

this
install -m 0644 -p fonts/*.pcf.gz $RPM_BUILD_ROOT%{fontdir}/
should be changed to
install -m 0644 -p *.pcf.gz $RPM_BUILD_ROOT%{fontdir}/

- this should be removed because it is not used:
%define buildsubdir     %{name}-%{version}

- in %prep
instead of
%{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version}
cd $RPM_BUILD_DIR/%{name}-%{version}
tar xfz %{SOURCE0}
this should be used:
%setup -q -n fonts


Comment 4 Akira TAGOH 2007-09-07 06:39:16 UTC
(In reply to comment #3)
> - Building with mock gives an error:
> + install -m 0644 -p 'fonts/*.pcf.gz'
> /var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/
> install: cannot stat `fonts/*.pcf.gz': No such file or directory

Doh. my bad. however:

> - in %prep
> instead of
> %{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version}
> cd $RPM_BUILD_DIR/%{name}-%{version}
> tar xfz %{SOURCE0}
> this should be used:
> %setup -q -n fonts

I'm worrying about following that since "fonts" is too generic and it might
affects to others perhaps.


Comment 5 Akira TAGOH 2007-09-07 06:49:03 UTC
Ok, updated. hopefully it should works enough.

Spec URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts-1.1-2.fc8.src.rpm


Comment 6 Mamoru TASAKA 2007-09-24 07:09:25 UTC
? - fonts-japanese spec file contains fonts.cache-1 and encodings.dir.
    Are these ghost files no longer needed?

Comment 7 Akira TAGOH 2007-09-24 07:54:13 UTC
Yes for this package at least, because those ghost are still required for
fonts-japanese to ensure removing all the files and the directories cleanly when
the package is removed so that it was generated outside the package. and this
package uses the different install dir and no longer created.

Comment 8 Akira TAGOH 2007-09-24 08:06:56 UTC
No, it isn't needed anymore, I meant.

Comment 9 Mamoru TASAKA 2007-09-24 08:22:06 UTC
Then okay for this package.

-----------------------------------------------------
  This package (knm_new-fonts) is APPROVED by me
-----------------------------------------------------

Comment 10 Parag AN(पराग) 2007-09-24 08:45:03 UTC
Thanks for quick review.

Comment 11 Akira TAGOH 2007-09-25 09:31:18 UTC
New Package CVS Request
=======================
Package Name: knm_new-fonts
Short Description: 12x12 JIS X 0208 Bitmap font
Owners: tagoh
Branches: devel
InitialCC: 
Cvsextras Commits: yes

Comment 12 Kevin Fenzi 2007-09-25 18:17:20 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.