Bug 285591
| Summary: | Review Request: lohit-fonts - font package for indic fonts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rahul Bhalerao <b.rahul.pm> | ||||||||
| Component: | Package Review | Assignee: | Jens Petersen <petersen> | ||||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | eng-i18n-bugs, fedora-package-review, notting, petersen | ||||||||
| Target Milestone: | --- | Flags: | petersen:
fedora-review+
petersen: fedora-cvs+ |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2007-09-24 13:34:45 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 253158 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rahul Bhalerao
2007-09-11 04:19:34 UTC
rpmlint output: lohit-fonts.src: E: no-changelogname-tag need a initial change entry explaining the package is derived from fonts-indic. lohit-fonts.src: W: invalid-license GPL License field needs to be updated, see: http://fedoraproject.org/wiki/Licensing I guess it should be GPLv2. Unless we have some explicit font embedding exception? Updated the files with the required changes. Thanks for the update. Please bump the release number for each new revision. The rpmlint output is clean now. :) Presumably for Indic we don't need fonts.dir and fonts.scale? How about a catalogue file? (http://fedoraproject.org/wiki/Releases/FeatureNoMoreXFS) My review follows: Good: + rpmlint clean + package follows upstream project name + package is based on fonts-indic + following Packaging Guidelines except as noted below + license is good (GPLv2) and included + spec file is clearly written + md5sum is pristine bb9497ee772062b97ff00a1a68b17c98 fonts-indic-2.1.5.tar.gz + builds correctly + filelists are correct + font install scriptlets are standard Bad: - should not Requires fontconfig explicitly Created attachment 194541 [details]
lohit-fonts.spec-1.patch
- also should not obsolete fonts-indic packages - they will now require
lohit-fonts
and some other things I noticed.
from https://bugzilla.redhat.com/show_bug.cgi?id=281901#c5, retain old Source tag instead one suggested in above patch. (In reply to comment #5) > from https://bugzilla.redhat.com/show_bug.cgi?id=281901#c5, retain old Source > tag instead one suggested in above patch. Ok fair enough - I should have rebuilt before posting... ;) (wget doesn't handle it well either - and we probably need a better location of future releases anyway, having it on the wiki is a little disconcerting.) Please put the full URL as a comment above the Source line. The changes have been made and the new srpm is available here: http://rbhalera.fedorapeople.org/lohit-fonts/lohit-fonts-2.1.5-2.fc8.src.rpm - please mention the actual changes made in the changelog - should not require fontconfig (see discussion on fedora-packaging list) rpmlint gives: lohit-fonts-bengali.noarch: W: no-version-in-last-changelog lohit-fonts-gujarati.noarch: W: no-version-in-last-changelog lohit-fonts-hindi.noarch: W: no-version-in-last-changelog lohit-fonts-kannada.noarch: W: no-version-in-last-changelog lohit-fonts-malayalam.noarch: W: no-version-in-last-changelog lohit-fonts-oriya.noarch: W: no-version-in-last-changelog lohit-fonts-punjabi.noarch: W: no-version-in-last-changelog lohit-fonts-tamil.noarch: W: no-version-in-last-changelog lohit-fonts-telugu.noarch: W: no-version-in-last-changelog Created attachment 201881 [details]
lohit-fonts.spec-2.patch
Here is a bunch of cleanup and fixes.
Probably this should be sufficient for this review.
Please review and make a changelog for it.
Created attachment 202561 [details]
lohit-fonts.spec-3.patch
additional patch to add lohit to fontdir names
Spec URL: http://paragn.fedorapeople.org/lohit-fonts.spec SRPM URL: http://paragn.fedorapeople.org/lohit-fonts-2.1.5-3.fc7.src.rpm please review this. Here is the review: Good: + rpmlint clean + package is named after upstream project name + meets packaging guidelines + license is gpl and included + spec files is clearly written + source is pristine bb9497ee772062b97ff00a1a68b17c98 fonts-indic-2.1.5.tar.gz + noarch package builds correctly + owns all dirs except /usr/share/fonts (owned by fontconfig) + macro usage is consistent All must items are satisfied afaict. Package is APPROVED. New Package CVS Request ======================= Package Name: lohit-fonts Short Description: Lohit TrueType fonts for Indic languages Owners: rbhalera Branches: devel InitialCC: petersen Cvsextras Commits: yes Jens, Thanks for review. cvsadmin done Thanks Parag for getting the package built. Maybe my indications on the license were not quite accurate. According to http://fedoraproject.org/wiki/Licensing/FAQ we reach (4) of the first question ("How do I figure out what version of the GPL/LGPL my package is under?") and so COPYING implies GPLv2+, if I'm not mistaken. Please update the License field to that in the next update. We should really make the version explicit in the README file say for the next release of Lohit fonts though (the .ttf files themselves just say GPL). |