Spec URL: http://rbhalera.fedorapeople.org/lohit-fonts/lohit-fonts.spec
SRPM URL: http://rbhalera.fedorapeople.org/lohit-fonts/lohit-fonts-2.1.5-1.fc8.src.rpm
Description: This package provides the Hindi, Bengali, Gujarati, Punjabi, Tamil,
Kannada, Malayalam, Oriya, Telugu TrueType/Opentype fonts.
lohit-fonts.src: E: no-changelogname-tag
need a initial change entry explaining the package is derived from fonts-indic.
lohit-fonts.src: W: invalid-license GPL
License field needs to be updated, see:
I guess it should be GPLv2. Unless we have some explicit font embedding exception?
Updated the files with the required changes.
Thanks for the update. Please bump the release number for each new revision.
The rpmlint output is clean now. :)
Presumably for Indic we don't need fonts.dir and fonts.scale?
How about a catalogue file?
My review follows:
+ rpmlint clean
+ package follows upstream project name
+ package is based on fonts-indic
+ following Packaging Guidelines except as noted below
+ license is good (GPLv2) and included
+ spec file is clearly written
+ md5sum is pristine
+ builds correctly
+ filelists are correct
+ font install scriptlets are standard
- should not Requires fontconfig explicitly
Created attachment 194541 [details]
- also should not obsolete fonts-indic packages - they will now require
and some other things I noticed.
from https://bugzilla.redhat.com/show_bug.cgi?id=281901#c5, retain old Source
tag instead one suggested in above patch.
(In reply to comment #5)
> from https://bugzilla.redhat.com/show_bug.cgi?id=281901#c5, retain old Source
> tag instead one suggested in above patch.
Ok fair enough - I should have rebuilt before posting... ;)
(wget doesn't handle it well either - and we probably need a better
location of future releases anyway, having it on the wiki is a little
Please put the full URL as a comment above the Source line.
The changes have been made and the new srpm is available here:
- please mention the actual changes made in the changelog
- should not require fontconfig (see discussion on fedora-packaging list)
lohit-fonts-bengali.noarch: W: no-version-in-last-changelog
lohit-fonts-gujarati.noarch: W: no-version-in-last-changelog
lohit-fonts-hindi.noarch: W: no-version-in-last-changelog
lohit-fonts-kannada.noarch: W: no-version-in-last-changelog
lohit-fonts-malayalam.noarch: W: no-version-in-last-changelog
lohit-fonts-oriya.noarch: W: no-version-in-last-changelog
lohit-fonts-punjabi.noarch: W: no-version-in-last-changelog
lohit-fonts-tamil.noarch: W: no-version-in-last-changelog
lohit-fonts-telugu.noarch: W: no-version-in-last-changelog
Created attachment 201881 [details]
Here is a bunch of cleanup and fixes.
Probably this should be sufficient for this review.
Please review and make a changelog for it.
Created attachment 202561 [details]
additional patch to add lohit to fontdir names
Spec URL: http://paragn.fedorapeople.org/lohit-fonts.spec
SRPM URL: http://paragn.fedorapeople.org/lohit-fonts-2.1.5-3.fc7.src.rpm
please review this.
Here is the review:
+ rpmlint clean
+ package is named after upstream project name
+ meets packaging guidelines
+ license is gpl and included
+ spec files is clearly written
+ source is pristine
+ noarch package builds correctly
+ owns all dirs except /usr/share/fonts (owned by fontconfig)
+ macro usage is consistent
All must items are satisfied afaict.
Package is APPROVED.
New Package CVS Request
Package Name: lohit-fonts
Short Description: Lohit TrueType fonts for Indic languages
Cvsextras Commits: yes
Thanks for review.
Thanks Parag for getting the package built.
Maybe my indications on the license were not quite accurate.
According to http://fedoraproject.org/wiki/Licensing/FAQ we reach (4)
of the first question ("How do I figure out what version of the GPL/LGPL
my package is under?") and so COPYING implies GPLv2+, if I'm not mistaken.
Please update the License field to that in the next update.
We should really make the version explicit in the README file say for the next
release of Lohit fonts though (the .ttf files themselves just say GPL).