Bug 305581
| Summary: | Review Request: bluecurve-kde-theme - Bluecurve KDE theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ray Strode [halfline] <rstrode> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, kevin, notting, rdieter, than |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
notting: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-11 15:56:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 305441, 305591 | ||
|
Description
Ray Strode [halfline]
2007-09-25 17:12:42 UTC
rpmlint output: [mclasen@localhost Desktop]$ rpmlint /var/lib/mock/fedora-development-i386/result/bluecurve-kde-theme-1.0.0-1.fc8.noarch.rpm bluecurve-kde-theme.noarch: W: invalid-license GPL package name: ok spec file name: ok packaging guidelines: ok license: ok license field: invalid license file: must be included spec language: English spec legibility: good upstream sources: no upstream yet buildable: ok ExcludeArch: n/a BRs: must BR kdebase-devel locales: ok shaerd libs: n/a relocatable: n/a directory ownership: ok %file: ok permissions: ok %clean: ok macro use: consistent content: permissible large docs: n/a %doc: ok headers: n/a static libs: n/a pc files: n/a shared libs: n/a devel package: n/a libtool archives: ok gui apps: n/a directory ownership: ok %install: ok utf8 filename: ok Further comment: Should capitalize bluecurve in the description why do I need to BuildRequires: kdebase-devel ? It's a noarch package. Maybe he assumed (like me) that this contained the Bluecurve kde widget style as well. :) That's in bluecurve-qt-engine then? Yup. I invented that name, so if you think it should be called bluecurve-kde-engine, or if the two packages should be merged into one bluecurve-kde-theme, just let me know. Where's the KWin theme? It's here: http://rstrode.fedorapeople.org/bluecurve-kwin-theme/checkout/ I apparently didn't file a review request for it. Will do so now (and double check that I didn't miss any others) It needs kdebase-devel because configure complains if it is not there... Just mock-build it and see. that's because configure has: KDE_SET_PREFIX KDE_CHECK_FINAL KDE_USE_QT AC_PATH_KDE to pull in $(kde_datadir) I don't know what those macros, I just copied it verbatim from redhat-artwork. For now i'll add the BuildRequires, but we might be able to trim that and drop the BuildReq or if we merge this with bluecurve-qt-engine, then this issue becomes moot. I'm still curious for opinions on that. I don't have an opinion on that. Either way works, but it seems a wee bit silly to me for bluecurve-kde-theme to include only 2 text config files... so, slight preference to merging bluecurve-qt-engine here. works for me, i'll make that change okay i've integrated the two now look good? Looks good to me. Approved. Not so quick... The license tag must be fixed here, it says "GPL+", but bluecurve.cpp actually specified version 2. updated to GPLv2 I think almost all the code copyright Red Hat, Inc. anyhow, so it probably doesn't really matter, but good to pick what works and be consistent. New Package CVS Request ======================= Package Name: bluecurve-kde-theme Short Description: Bluecurve-kde-theme Owners: rstrode,davidz,than,rdieter,kkofler Branches: InitialCC: Cvsextras Commits: no done |