Red Hat Bugzilla – Bug 305581
Review Request: bluecurve-kde-theme - Bluecurve KDE theme
Last modified: 2007-11-30 17:12:16 EST
This package contains a kde theme that uses the qt bluecurve engine.
[mclasen@localhost Desktop]$ rpmlint
bluecurve-kde-theme.noarch: W: invalid-license GPL
package name: ok
spec file name: ok
packaging guidelines: ok
license field: invalid
license file: must be included
spec language: English
spec legibility: good
upstream sources: no upstream yet
BRs: must BR kdebase-devel
shaerd libs: n/a
directory ownership: ok
macro use: consistent
large docs: n/a
static libs: n/a
pc files: n/a
shared libs: n/a
devel package: n/a
libtool archives: ok
gui apps: n/a
directory ownership: ok
utf8 filename: ok
Should capitalize bluecurve in the description
why do I need to BuildRequires: kdebase-devel ?
It's a noarch package.
Maybe he assumed (like me) that this contained the Bluecurve kde widget style as
That's in bluecurve-qt-engine then?
Yup. I invented that name, so if you think it should be called
bluecurve-kde-engine, or if the two packages should be merged into one
bluecurve-kde-theme, just let me know.
Where's the KWin theme?
It's here: http://rstrode.fedorapeople.org/bluecurve-kwin-theme/checkout/
I apparently didn't file a review request for it. Will do so now (and double
check that I didn't miss any others)
It needs kdebase-devel because configure complains if it is not there...
Just mock-build it and see.
that's because configure has:
to pull in $(kde_datadir)
I don't know what those macros, I just copied it verbatim from redhat-artwork.
For now i'll add the BuildRequires, but we might be able to trim that and drop
or if we merge this with bluecurve-qt-engine, then this issue becomes moot. I'm
still curious for opinions on that.
I don't have an opinion on that.
Either way works, but it seems a wee bit silly to me for bluecurve-kde-theme to
include only 2 text config files... so, slight preference to merging
works for me, i'll make that change
okay i've integrated the two now
Looks good to me. Approved.
Not so quick... The license tag must be fixed here, it says "GPL+", but
bluecurve.cpp actually specified version 2.
updated to GPLv2
I think almost all the code copyright Red Hat, Inc. anyhow, so it probably
doesn't really matter, but good to pick what works and be consistent.
New Package CVS Request
Package Name: bluecurve-kde-theme
Short Description: Bluecurve-kde-theme
Cvsextras Commits: no