Bug 315021

Created attachment 290012 [details]
Updated spec file for 1.0.1

Updates to 1.0.1 release.  Fix up how we install documentation.

Created attachment 290013 [details]
Updated patch for ElementTree dependency

Updates the existing 0.10.1 patch to the same as in Subversion.

Created attachment 290144 [details]
1.0.1-2 Add the ability to create manpages

The spec file will now also generate manpages for the various tools.

ping?

Thanks for the patches, Dwayne!

I updated devel to 1.0.1 with them.
It would be good to do an update soon for F8 too.

Thanks Jens,

Is there anything I can help with/need to do in terms of getting the F8 update
through?

*** Bug 427611 has been marked as a duplicate of this bug. ***

Asking Caius to help backport the update to F8.

(In reply to comment #6)
> Is there anything I can help with/need to do in terms of getting the F8 update
> through?

Well, Dwayne, you could sanity check the changes for F8 and help test
the package when it lands in the testing repo. :)

BTW, could you please explain about

Requires:       python-Levenshtein
Requires:       python-psyco

you added in your patch?  Does psyco give a big increase in performance?
(I don't see python-Levenshtein in fedora, but maybe it is in koji?)

Built translate-toolkit-1.0.1-1.fc8 and pushed to bodhi.

(In reply to comment #9)
> BTW, could you please explain about
> 
> Requires:       python-Levenshtein
> Requires:       python-psyco
> 
> you added in your patch?  Does psyco give a big increase in performance?
> (I don't see python-Levenshtein in fedora, but maybe it is in koji?)

Re: python-Levenshtein
You are correct this isn't in Fedora, my bad for not checking more carefully. 
The toolkit will fallback to using a Python version which is much slower if
python-Levenshtein is missing.  I'll have to look at building an RPM separately
for that.  So this dependency can be safely removed for now.

The site that originally hosted it seems to be gone:
http://trific.ath.cx/python/levenshtein/
but I have the 0.10.1 source on my computer. And here are other RPM builds:

http://rpm.pbone.net/index.php3/stat/4/idpl/4454315/com/python-Levenshtein-0.10-0.1.i486.rpm.html


Re: Psyco
These are the outputs from the 3rd of 3 runs first without and then without psyco.

[dwayne@dhcppc32 convert]$ time -p oo2po --psyco=none -P en-US-stable.sdf ooslow
processing 246 files...
[###########################################] 100%
real 211.97
user 203.46
sys 3.35

[dwayne@dhcppc32 convert]$ time -p oo2po --psyco=full -P en-US-stable.sdf oofast
processing 246 files...
[###########################################] 100%
real 235.11
user 140.85
sys 5.72

So yes it does make a substantial difference.  Without it the conversion from
OpenOffice.org SDF to PO takes 3:20 and with it it takes 2:20.  Shaving off a
minute of execution time.

(In reply to comment #9)
> Requires:       python-Levenshtein

Bug 429882 is for packaging the C based Levenshtein functionality.

translate-toolkit-1.0.1-1.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update translate-toolkit'

We could create another bug for requiring python-Levenshtein in
translate-toolkit. The bug will depend on bug#429882 and be processed right
after such bug.

(In reply to comment #14)
> We could create another bug for requiring python-Levenshtein in
> translate-toolkit. The bug will depend on bug#429882 and be processed right
> after such bug.

Good suggestion, and we could add the python-psyco dep to devel now I guess.

(In reply to comment #15)
> (In reply to comment #14)
> > We could create another bug for requiring python-Levenshtein in
> > translate-toolkit. The bug will depend on bug#429882 and be processed right
> > after such bug.
> 
> Good suggestion, and we could add the python-psyco dep to devel now I guess.

Bug 430887 is such a bug and its blocked by this one and the packaging of
python-Levenshtein.

I've been running with the Fedora version for a few days and all seems to be
working correctly.

translate-toolkit-1.0.1-3.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update translate-toolkit'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-1294

Created attachment 293986 [details]
1.0.1-4 Remove python-Levenshtein dependency

I tested the current 1.0.1-3 build in a clean environment, i.e. all required
pacakages removed.  This fails as 1.0.1-3 still requires python-Levenshtein.

The patch removes the requirements, updates the release number and changelog.

translate-toolkit-1.0.1-1.fc8 was the package that was supposed to be tested
and pushed.  I requested it be pushed to stable now anyway.

translate-toolkit-1.0.1-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Thanks to everyone for the help on this bug and apologies for my confusion
around 1.0.1-1 vs 1.0.1-3.