Bug 336601

Summary: bind segfaults when incorrectly configured to use dbus
Product: [Fedora] Fedora Reporter: Peter Jones <pjones>
Component: bindAssignee: Adam Tkac <atkac>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: rawhideCC: mbroz, ovasik
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-10-22 08:24:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fix va_start calls that don't call va_end
none
gdb log none

Description Peter Jones 2007-10-17 19:32:10 UTC 
Description of problem: In certain situations when bind is configured to use
dbus, but the other dbus client it would be communicating with isn't present,
bind will segfault.

Version-Release number of selected component (if applicable):
bind-9.5.0-14.a6.fc8

How reproducible:
Happens pretty much every time if the start order is wrong (which I think is
generally true if you've upgraded) and it's configured to use dbus.

Steps to Reproduce:
1. service bind start
2.
3.
  
Actual results:
Log messages that say:
Oct 17 13:58:47 localhost named[29213]: dbus_svc_add_filter failed
Oct 17 13:58:47 localhost named[29213]: dbus_mgr initialization failed. D-BUS
service is disabled.
Oct 17 13:58:47 localhost named[29213]: running
Oct 17 13:58:47 localhost kernel: named[29215]: segfault at 348c7da0 eip
0044c1ff esp b74e9240 error 6

Expected results:
first 3 log messages, then no segfault.

Additional info:
This actually seems to be caused by the error logging functions in bind's dbus
initialization code, which call va_start but not always va_end.  I've attached a
patch which fixes the problem.
Comment 1 Peter Jones 2007-10-17 19:32:10 UTC 
Created attachment 230311 [details]
fix va_start calls that don't call va_end
Comment 2 Adam Tkac 2007-10-18 12:35:12 UTC 
I'm not sure if your crash is caused by missing va_end but patch is correct.
I've removed statement which patches idnkit because this part is already
obsolete and We're using libidn for IDN support. Thanks for patch.

Adam
Comment 3 Adam Tkac 2007-10-19 08:43:46 UTC 
I've got next report which will be related to this. Could you test updated
package (http://kojiweb.fedoraproject.org/koji/taskinfo?taskID=202749) ASAP,
please? This issue should be fixed in F8 final.
Comment 4 Milan Broz 2007-10-20 19:09:43 UTC 
Created attachment 233521 [details]
gdb log

I see this after upgrading too, even with new build
# rpm -q bind dbus
bind-9.5.0-15.1.a6.fc8
dbus-1.1.2-7.fc8

See attached gdb session log.
Comment 5 Adam Tkac 2007-10-22 08:24:58 UTC 

*** This bug has been marked as a duplicate of 339191 ***