Bug 361191
| Summary: | Review Request: rubygem-rails - Web-application framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Lutterkort <lutter> |
| Component: | Package Review | Assignee: | Scott Seago <sseago> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | amlau, fedora-package-review, hbrock, notting, tdawson |
| Target Milestone: | --- | Flags: | sseago:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-03 23:51:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 361201, 361211, 361231, 361241, 361251 | ||
| Bug Blocks: | |||
|
Description
David Lutterkort
2007-11-01 01:46:37 UTC
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent
OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch
??? - BuildRoot value: not sure if this is really a problem, but it
looks like %{release} is omitted:
BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
vs.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
FIX - rpmlint complains
E: rubygem-rails zero-length
/usr/lib/ruby/gems/1.8/gems/rails-1.2.5/configs/empty.log
E: rubygem-rails zero-length
/usr/lib/ruby/gems/1.8/gems/rails-1.2.5/html/favicon.ico
I fixed the buildroot. The two files rpmlint complains about are empty upstream - I did not want to remove them to minimize differences between the gem and the rpm Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-rails.spec SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-rails-1.2.5-2.src.rpm approved New Package CVS Request ======================= Package Name: rubygem-rails Short Description: Web-application framework Owners: lutter,sseago Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes Looks like an update to 1.2.6 before pushing this would be a good idea: http://nvd.nist.gov/nvd.cfm?cvename=CVE-2007-6077 cvs done. scop: thanks for pointing to the CVE. I did update to 1.2.6. Successfully imported and built. Package Change Request ====================== Package Name: rubygem-rails New Branches: epel7 Owners: tdawson Git done (by process-git-requests). |