Bug 398911 (perl-Scope-Guard)

Summary:	Review Request: perl-Scope-Guard - Lexically scoped resource management
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, tremble
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Scope-Guard/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-11-26 18:43:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	411551

Description Chris Weyl 2007-11-25 23:57:26 UTC

SRPM URL: http://fedora.biggerontheinside.net/review/perl-Scope-Guard-0.03-1.fc6.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Scope-Guard.spec

Description:
This module provides a convenient way to perform cleanup or other forms of
resource management at the end of a scope. It is particularly useful when
dealing with exceptions: the Scope::Guard constructor takes a reference to
a subroutine that is guaranteed to be called even if the thread of
execution is aborted prematurely. This effectively allows lexically-scoped
"promises" to be made that are automatically honoured by perl's garbage
collector.

Comment 1 Chris Weyl 2007-11-25 23:58:07 UTC

This is a DBIx::Class prereq.

Comment 2 Parag AN(पराग) 2007-11-26 01:44:05 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
a33ab0a31d837b94797e61050afff894  Scope-Guard-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains contents.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ make test output
t/pod.............ok
t/pod_coverage....ok
t/Scope-Guard.....ok
All tests successful.
Files=3, Tests=10,  0 wallclock secs ( 0.21 cusr +  0.03 csys =  0.24 CPU)
+ Package perl-Scope-Guard-0.03-1.fc9 ->
  Provides: perl(Scope::Guard) = 0.03
+ Not a GUI app.

APPROVED.

Comment 3 Chris Weyl 2007-11-26 06:00:41 UTC

New Package CVS Request
=======================
Package Name: perl-Scope-Guard
Short Description: Lexically scoped resource management
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2007-11-26 17:53:58 UTC

cvs done.

Comment 5 Chris Weyl 2007-11-26 18:43:21 UTC

Imported and built.  Thanks for the review! :)

Comment 6 Mark Chappell 2010-07-09 10:09:18 UTC

Package Change Request
======================
Package Name: perl-Scope-Guard
New Branches: EL-6
Owners: tremble    

cweyl has previously expressed that he is happy for others to request EPEL branches

Comment 7 Kevin Fenzi 2010-07-09 18:10:19 UTC

CVS done (by process-cvs-requests.py).