SRPM URL: http://fedora.biggerontheinside.net/review/perl-Scope-Guard-0.03-1.fc6.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Scope-Guard.spec Description: This module provides a convenient way to perform cleanup or other forms of resource management at the end of a scope. It is particularly useful when dealing with exceptions: the Scope::Guard constructor takes a reference to a subroutine that is guaranteed to be called even if the thread of execution is aborted prematurely. This effectively allows lexically-scoped "promises" to be made that are automatically honoured by perl's garbage collector.
This is a DBIx::Class prereq.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. a33ab0a31d837b94797e61050afff894 Scope-Guard-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + make test output t/pod.............ok t/pod_coverage....ok t/Scope-Guard.....ok All tests successful. Files=3, Tests=10, 0 wallclock secs ( 0.21 cusr + 0.03 csys = 0.24 CPU) + Package perl-Scope-Guard-0.03-1.fc9 -> Provides: perl(Scope::Guard) = 0.03 + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: perl-Scope-Guard Short Description: Lexically scoped resource management Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Imported and built. Thanks for the review! :)
Package Change Request ====================== Package Name: perl-Scope-Guard New Branches: EL-6 Owners: tremble cweyl has previously expressed that he is happy for others to request EPEL branches
CVS done (by process-cvs-requests.py).