Bug 426576
Summary: | [PATCH] macbook 3.1 and apple aluminum keyboards fn key does not work | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Nolan <chris> |
Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | low | ||
Version: | 8 | CC: | chris.brown, dwmw2, johan-fedora |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 2.6.24.3-50.fc8 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-03-26 17:15:08 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Attachments: |
Description
Chris Nolan
2007-12-22 13:57:53 UTC
Created attachment 290294 [details] Test kernel patch for 2.6.23 x86_64 Test kernel patch for 2.6.23 x86_64 This is a kernel patch to fix both this bug (426576) and 426574 - the appletouch.c part of this patch is not relevant to this bug but is relevant to 426574. (Maybe the bugs should be merged or maybe the patches should be split up). It seems to work for me, but needs testing. Based on patch from ubuntu at https://bugs.edge.launchpad.net/ubuntu/+source/linux-meta/+bug/162083 Note: I am not sure of the upstream status of these fixes - the ubuntu bug tracker suggests some of the fixes may already be applied upstream in 2.6.24 Chris, as you suggested in comment #1, I'm closing this bug as a duplicate of #426574. Keeping two bug reports for the same patch does not seem very useful. *** This bug has been marked as a duplicate of 426574 *** Johan, are you sure this should be treated as the same/duplicate bug? The bugs themselves are quite different - this one relates to the apple "fn" key while #426574 relates to the touchpad and appletouch/synaptics. I am not sure, but I feel it may make more sense for me to create separate patch files for each bug rather than combine the bugs? I must have missed something when looked at this report yesterday. It didn't seem reasonable to have two bugs with the same patch, but there are two issues here. I probably just read 'macbook', 'input device' and the identical patch in both reports. Splitting this patch in two separate patches is a valid idea. Chris, can you split the proposed patch for these two problems and attach them to the correct bugs? Created attachment 292293 [details]
Updated kernel patch for 2.6.23 x86_64
This is an updated kernel patch containing proposed kernel fixes for this bug
only.
I have yet to test this individual patch but I will update this report once I
have done so. We could really use some more people with the macbook 3,1 to test
this also.
Created attachment 294650 [details]
Updated kernel patch for 2.6.23 x86_64
Cleaner version of the same patch. Tested with 2.6.23.15-137 and works fine.
Chris, Have posted this to lkml? No, should I? Most definitely. You'd get more review and testing of the code. Can we get this patch pushed into the kernel? The patch for bug #426574 has been included for several releases, but that patch is useless (it simply does not work) without this patch also being included. Does this patch do the same thing? It looks slightly different... http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=5906a0448208024d140e1ee0e65f9168a405fb94 Yes, that patch does appear to do the same thing, but for the 2.6.25 kernel which it seems has undergone quite a few modifications in order to support the apple keyboards. There is another earlier patch here: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff_plain;h=a45d82d19a6c2a717bcc33cff243199b77fa0082 From these it appears that 2.6.25 will support this (and other) apple keyboards by default. Looks like they added a kernel configuration option to enable/disable support too. I wonder if they also added support for the trackpad - I guess so (bug #426574). If there is a Fedora 2.6.25 kernel that I can install under F8 alongside my current kernel for testing purposes then I will give that a go and see how it works. Meanwhile, us Macbook users would be extremely pleased if you could patch the current 2.6.24 F8 kernel - I'd love to be able to use a stock Fedora kernel! Created attachment 298060 [details]
Updated kernel patch for 2.6.24 x86_64
This is an updated patch from the mactel-linux site for kernel 2.6.24.
I have tested this with 2.6.24.3-34 x86_64 and it works great.
Chris will you be releasing rpms at http://www.cenolan.com/fedora8/ for 2.6.24.3-34? I would love to not have to compile from scratch as I have been having trouble getting them to boot on my MacBook for whatever weird reason. (In reply to comment #14) > Chris will you be releasing rpms at http://www.cenolan.com/fedora8/ for 2.6.24.3-34? > > I would love to not have to compile from scratch as I have been having trouble > getting them to boot on my MacBook for whatever weird reason. Yes, I'll put my patched kernel up ASAP. Created attachment 298521 [details]
Update to Apple aluminum keyboard key mappings
Looks like they will change the key mappings before 2.6.25 gets released...
Not sure I entirely agree with those new key mappings but I'll trust they know what they're doing more than me! At least it looks like 2.6.25 will have full support for Mac keyboards/touchpads. Now, as for 2.6.24 - can we get this patch included? PLEASE!! It would be a great feather in the cap for F8 to have full support for the macbook out-of-the-box. And I'm sick of compiling kernels ;) In 2.6.24.3-47 kernel-2.6.24.3-50.fc8 has been submitted as an update for Fedora 8 kernel-2.6.24.3-50.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kernel'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-2630 kernel-2.6.24.3-50.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. kernel-2.6.24.3-50.fc8 works beautifully, thank you! The patch which went upstream for this seems to have a different set of quirks for USB_DEVICE_ID_APPLE_WELLSPRING2_ISO -- and the touchpad doesn't work there. I suspect it won't work on the rawhide kernel either, although it works with F-9. |