Bug 426645
| Summary: | Review Request: perl-XML-Tidy - Tidy indenting of XML documents | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-28 22:27:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 426644 | ||
| Bug Blocks: | 426646 | ||
|
Description
Xavier Bachelot
2007-12-23 16:17:42 UTC
oops, missing SRPM URL : http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Tidy-1.2.54HJnFa-2.fc8.src.rpm missing BuildRequires: perl(ExtUtils::MakeMaker) Fixed in http://washington.kelkoo.net/fedora/SPECS/perl-XML-Tidy.spec http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Tidy-1.2.54HJnFa-3.fc8.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8bafc2d11f95c403b3a7d732c5ed494d XML-Tidy-1.2.54HJnFa.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is t/00small.....ok t/01medium....ok t/02large.....ok t/03prune.....ok All tests successful. Files=4, Tests=60, 0 wallclock secs ( 0.45 cusr + 0.06 csys = 0.51 CPU) + Package perl-XML-Tidy-1.2.54HJnFa-3.fc9 -> Provides: perl(XML::Tidy) = 1.2.54 Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(Math::BaseCnv) perl(XML::XPath) perl(XML::XPath::XMLParser) perl(base) perl(strict) perl(vars) perl(warnings) APPROVED. Thx for the review Parag. New Package CVS Request ======================= Package Name: perl-XML-Tidy Short Description: Tidy indenting of XML documents Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. Thx Kevin. Imported and build for devel and F-8. |