Red Hat Bugzilla – Bug 426646
Review Request: perl-XML-Merge - Flexibly merge XML documents
Last modified: 2008-01-02 08:24:00 EST
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-XML-Merge.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Merge-1.2.565EgGd-1.fc8.src.rpm
This module inherits from XML::Tidy which in turn inherits from XML::XPath. This ensures that Merge objects' indenting can be tidied up after any merge operation since such modification usually spells the ruination of indentation. Polymorphism allows Merge objects to be utilized as normal XML::XPath objects as well. The merging behavior is setup to combine separate XML documents according to certain rules and configurable options. If both documents have root nodes which are elements of the same name, the documents are merged directly. Otherwise, one is merged as a child of the other. An optional XPath location can be specified as the place to perform the merge. If no location is specified, the
merge is attempted at the first matching element or is appended as the new last
child of the other root if no match is found.
New version with fixed Release tag :
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
All tests successful.
Files=3, Tests=45, 1 wallclock secs ( 1.03 cusr + 0.05 csys = 1.08 CPU)
+ Package perl-XML-Merge-1.2.565EgGd-2.fc9 ->
Provides: perl(XML::Merge) = 1.2.565
Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(XML::Tidy) perl(base)
Thx for the review Parag.
New Package CVS Request
Package Name: perl-XML-Merge
Short Description: Flexibly merge XML documents
Cvsextras Commits: yes
Imported and built in devel.
Imported and tagged in F-8, but build failed because perl-XML-Tidy is not