Bug 426645 - Review Request: perl-XML-Tidy - Tidy indenting of XML documents
Summary: Review Request: perl-XML-Tidy - Tidy indenting of XML documents
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 426644
Blocks: 426646
TreeView+ depends on / blocked
 
Reported: 2007-12-23 16:17 UTC by Xavier Bachelot
Modified: 2007-12-28 22:27 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-12-28 22:27:25 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Bachelot 2007-12-23 16:17:42 UTC
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-XML-Tidy.spec
SRPM URL: 
Description: This module creates XML document objects (with inheritance from XML::XPath) to tidy mixed-content (ie. non-data) text node indenting. There are also some other handy member functions to compress && expand your XML document object (into either a compact XML representation or a binary one).

Comment 1 Xavier Bachelot 2007-12-23 16:19:04 UTC
oops, missing SRPM URL :
http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Tidy-1.2.54HJnFa-2.fc8.src.rpm

Comment 2 Parag AN(पराग) 2007-12-26 04:52:59 UTC
missing
BuildRequires:  perl(ExtUtils::MakeMaker)


Comment 4 Parag AN(पराग) 2007-12-27 05:47:44 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8bafc2d11f95c403b3a7d732c5ed494d  XML-Tidy-1.2.54HJnFa.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
t/00small.....ok
t/01medium....ok
t/02large.....ok
t/03prune.....ok
All tests successful.
Files=4, Tests=60,  0 wallclock secs ( 0.45 cusr +  0.06 csys =  0.51 CPU)
+ Package perl-XML-Tidy-1.2.54HJnFa-3.fc9 ->
  Provides: perl(XML::Tidy) = 1.2.54
  Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter)
perl(Math::BaseCnv) perl(XML::XPath) perl(XML::XPath::XMLParser) perl(base)
perl(strict) perl(vars) perl(warnings)

APPROVED.


Comment 5 Xavier Bachelot 2007-12-27 19:07:44 UTC
Thx for the review Parag.

New Package CVS Request
=======================
Package Name: perl-XML-Tidy
Short Description: Tidy indenting of XML documents
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2007-12-28 17:43:37 UTC
cvs done.

Comment 7 Xavier Bachelot 2007-12-28 22:27:25 UTC
Thx Kevin.

Imported and build for devel and F-8.


Note You need to log in before you can comment on or make changes to this bug.