Bug 428112
| Summary: | Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Xavier Bachelot <xavier> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-09 21:13:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 428113 | ||
|
Description
Xavier Bachelot
2008-01-09 10:51:58 UTC
Just one small thing i saw that is:
i would replace
%{__perl} Makefile.PL INSTALLDIRS=vendor
with
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
I am also not sure if we need " || :" after check
(In reply to comment #1) > Just one small thing i saw that is: > i would replace > %{__perl} Makefile.PL INSTALLDIRS=vendor > with > %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" > This is a noarch package, so OPTIMIZE is not needed. > I am also not sure if we need " || :" after check You're right, it is not in the template, I'll remove it. As this package is not compiling anything in build stage no need of OPTIMIZE="$RPM_OPT_FLAGS" I don't think you need to set -x and set +x Don't think you need %check ||: Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4d3f84ba4e35cb7fac863b828b7f2b68 HTML-PrettyPrinter-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..3 # Running under perl version 5.008008 for linux # Current time local: Wed Jan 9 06:55:34 2008 # Current time GMT: Wed Jan 9 11:55:34 2008 # Using Test.pm version 1.25 ok 1 ok 1 ok 2 ok 3 exit 0 + Package perl-HTML-PrettyPrinter-0.03-1.fc9 -> Provides: perl(HTML::PrettyPrinter) = 0.03 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict) perl(vars) APPROVED. Thx Parag. %check and set -x/set +x fixed in : http://washington.kelkoo.net/fedora/SPECS/perl-HTML-PrettyPrinter.spec http://washington.kelkoo.net/fedora/SRPMS/perl-HTML-PrettyPrinter-0.03-2.fc8.src.rpm New Package CVS Request ======================= Package Name: perl-HTML-PrettyPrinter Short Description: Generate nice HTML files from HTML syntax trees Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes cvs done. Thanks Kevin. Imported and built for devel and F-8. |