Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Net-eBay.spec SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-Net-eBay-0.45-1.fc8.src.rpm Description: This module helps user to easily execute queries against eBay's XML API.
will review this once its dependent packages will be built.
Thanks Parag. Btw, please note this one have a missing BR: on perl(Test::Pod::Coverage). Some functions are not documented, thus the test fails. I've filled a bug upstream http://rt.cpan.org/Ticket/Display.html?id=32184 and documented this in the spec.
http://koji.fedoraproject.org/koji/taskinfo?taskID=388797 From build log it looked like you need to include some BRs Warning: prerequisite HTML::FormatText 0 not found. Warning: prerequisite HTML::PrettyPrinter 0 not found. Warning: prerequisite HTML::TreeBuilder 0 not found.
How did I let that pass thru ? Fixed in : Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Net-eBay.spec SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-Net-eBay-0.45-2.fc8.src.rpm
One Requires: was missing from the repos too, bug #431237.
New upstream version, with fixed documentation. I re-enabled BR: on perl(Test::Pod::Coverage) Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Net-eBay.spec SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-Net-eBay-0.46-1.fc8.src.rpm
unable to download upstream source tarball.
hmm, weird, it works for me, I tested again this morning.
hey it worked now :)
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 175674e914326a6af84564acfb57286b Net-eBay-0.46.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is t/00-load.........# Testing Net::eBay 0.46, Perl 5.008008, /usr/bin/perl ok t/pod-coverage....ok t/pod.............ok All tests successful. Files=3, Tests=22, 1 wallclock secs ( 0.64 cusr + 0.05 csys = 0.69 CPU) + Package perl-Net-eBay-0.46-1.fc9 -> Provides: perl(Net::eBay) = 0.46 Requires: /usr/bin/perl perl(Carp) perl(Cwd) perl(Data::Dumper) perl(DateTime::Precise) perl(Getopt::Long) perl(HTML::FormatText) perl(HTML::PrettyPrinter) perl(HTML::TreeBuilder) perl(HTTP::Date) perl(HTTP::Request::Common) perl(HTTP::Status) perl(LWP::UserAgent) perl(Net::eBay) perl(Text::Format) perl(XML::Dumper) perl(XML::Simple) perl(strict) perl(utf8) perl(vars) perl(warnings) SHOULD: Remove OPTIMIZE="$RPM_OPT_FLAGS" from make coammand APPROVED.
Thx Parag. I'll fix the last problem before importing. New Package CVS Request ======================= Package Name: perl-Net-eBay Short Description: Perl Interface to XML based eBay API Owners: xavierb Branches: F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: yes
cvs done.
Imported and built for devel, F-8 and EL-5.