Bug 428112 - Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees
Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML ...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 428113
  Show dependency treegraph
 
Reported: 2008-01-09 05:51 EST by Xavier Bachelot
Modified: 2008-01-09 16:13 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-09 16:13:24 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Xavier Bachelot 2008-01-09 05:51:58 EST
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-HTML-PrettyPrinter.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-HTML-PrettyPrinter-0.03-1.fc8.src.rpm
Description: HTML::PrettyPrinter produces nicely formatted HTML code from a HTML syntax tree. It is especially useful if the produced HTML file shall be read or edited manually afterwards. Various parameters let you adapt the output to different styles and requirements.
Comment 1 Huzaifa S. Sidhpurwala 2008-01-09 06:06:53 EST
Just one small thing i saw that is:
i would replace 
%{__perl} Makefile.PL INSTALLDIRS=vendor
with
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"

I am also not sure if we need " || :" after check
Comment 2 Xavier Bachelot 2008-01-09 06:21:49 EST
(In reply to comment #1)
> Just one small thing i saw that is:
> i would replace 
> %{__perl} Makefile.PL INSTALLDIRS=vendor
> with
> %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> 
This is a noarch package, so OPTIMIZE is not needed.

> I am also not sure if we need " || :" after check

You're right, it is not in the template, I'll remove it.
Comment 3 Parag AN(पराग) 2008-01-09 07:07:36 EST
As this package is not compiling anything in build stage no need of
OPTIMIZE="$RPM_OPT_FLAGS"

I don't think you need to set -x and set +x

Don't think you need %check ||:



Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
4d3f84ba4e35cb7fac863b828b7f2b68  HTML-PrettyPrinter-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
1..3
# Running under perl version 5.008008 for linux
# Current time local: Wed Jan  9 06:55:34 2008
# Current time GMT:   Wed Jan  9 11:55:34 2008
# Using Test.pm version 1.25
ok 1
ok 1
ok 2
ok 3
exit 0
+ Package perl-HTML-PrettyPrinter-0.03-1.fc9 ->
  Provides: perl(HTML::PrettyPrinter) = 0.03
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict)
perl(vars)
APPROVED.

  
Comment 4 Xavier Bachelot 2008-01-09 08:45:20 EST
Thx Parag.
%check and set -x/set +x fixed in :
http://washington.kelkoo.net/fedora/SPECS/perl-HTML-PrettyPrinter.spec
http://washington.kelkoo.net/fedora/SRPMS/perl-HTML-PrettyPrinter-0.03-2.fc8.src.rpm

New Package CVS Request
=======================
Package Name: perl-HTML-PrettyPrinter
Short Description: Generate nice HTML files from HTML syntax trees
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes
Comment 5 Kevin Fenzi 2008-01-09 13:22:15 EST
cvs done.
Comment 6 Xavier Bachelot 2008-01-09 16:13:24 EST
Thanks Kevin.

Imported and built for devel and F-8.

Note You need to log in before you can comment on or make changes to this bug.