Bug 428586
Summary: | Review Request: ldm - LTSP Display Manager | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> | ||||||
Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | fedora-package-review, notting | ||||||
Target Milestone: | --- | Flags: | a.badger:
fedora-review+
wtogami: fedora-cvs+ |
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2008-03-10 05:24:25 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 188611 | ||||||||
Attachments: |
|
Description
Warren Togami
2008-01-13 21:18:43 UTC
Good: * spec matches the base package. * License is GPLv2+ * License is included with package. * Spec is coherent American English * Package builds and installs on i386 * Not a library Needswork: * Is this a pre-release snapshot? If so the release should be 0.1.20080114. [Fix attached] * Source needs to have instructions for retrieving from upstream (since it's a snapshot) [Fix attached] * Not all BuildRequires are listed: Needs gtk2-devel, does not need libtool [Fix attached] * Needs to own %{_datadir}/ldm [Fix attached] * rpmlint output:: ldm.i386: E: non-executable-script /usr/share/ldm/ldm-script 0644 This looks like a script that is intended to start and stop services when a user logs into the box. Does it need to be executable? [Not fixed] Notes: * When upstream releases a tarball of this package it will likely be named ldm2 (judging from the tarball that make dist creates). Since the main binary is named ldm and we're not likely to package ldm1 ever, I think naming this package ldm is fine. * No locales are currently installed but there are some translations available. When those are installed, be sure to include them using %{find_lang} so that they are properly marked as language files. * Although this is a graphical application, it does not need a .desktop file because it does not run from a desktop session. Instead it is used to start a desktop session. I'll attach a new spec file in a moment that addresses most of the issues. Created attachment 291708 [details]
spec file solving most review issues
This solves all review issues except whether /usr/share/ldm/ldm-script schould
be executable and if so, whether it belongs in /usr/share/ or somewhere else
like /usr/libexec.
http://togami.com/~warren/fedora/ldm.spec http://togami.com/~warren/fedora/ldm-0.1-0.3.20080116.fc8.src.rpm Built on top of your upstream changes... you made ldm-script and rc.d install into libexecdir without the trailing /ldm. Please check that I fixed this properly? APPROVED Looks good. I changed the README to reflect your changes to libexecdir and pushed upstream. Only one thing left to be fixed in the spec file: * Need to have checkout instructions for getting the source for revision control: http://fedoraproject.org/wiki/Packaging/SourceURL For instance:: # bzr snapshot:: # bzr checkout --lightweight -r 791 http://bazaar.launchpad.net/~ltsp-upstream/ltsp/ldm-trunk # cd ldm-trunk # ./mkdst --test # tarball is ldm-%{version}.tar.bz2 Fix this when you checkin and this package is approved. Note: I also notice that gcc is throwing several valid warnings. I'm attaching a patch for you to review that fixes most of them. I didn't fix any of the:: "warning: ignoring return value of ‘write’, declared with attribute warn_unused_result" because I'm not sure how you want to deal with those. Created attachment 291998 [details]
Fix many warnings issued by gcc.
http://wtogami.livejournal.com/23144.html Description of blocker in LDM that needs to be fixed before Fedora 9. OK well this is in F-9, so closing. |