Bug 428586 - Review Request: ldm - LTSP Display Manager
Review Request: ldm - LTSP Display Manager
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Toshio Ernie Kuratomi
Fedora Extras Quality Assurance
Depends On:
Blocks: K12LTSP
  Show dependency treegraph
Reported: 2008-01-13 16:18 EST by Warren Togami
Modified: 2008-03-10 01:24 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-03-10 01:24:25 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
a.badger: fedora‑review+
wtogami: fedora‑cvs+

Attachments (Terms of Use)
spec file solving most review issues (1.15 KB, text/plain)
2008-01-15 07:58 EST, Toshio Ernie Kuratomi
no flags Details
Fix many warnings issued by gcc. (3.28 KB, patch)
2008-01-17 09:25 EST, Toshio Ernie Kuratomi
no flags Details | Diff

  None (edit)
Description Warren Togami 2008-01-13 16:18:43 EST
LTSP Display Manager
(exhausted... I will add a better description later)
Comment 1 Toshio Ernie Kuratomi 2008-01-15 07:54:54 EST
* spec matches the base package.
* License is GPLv2+
* License is included with package.
* Spec is coherent American English
* Package builds and installs on i386
* Not a library

* Is this a pre-release snapshot?  If so the release should be 0.1.20080114.
  [Fix attached]
* Source needs to have instructions for retrieving from upstream (since it's a
  [Fix attached]
* Not all BuildRequires are listed: Needs gtk2-devel, does not need libtool
  [Fix attached]
* Needs to own %{_datadir}/ldm
  [Fix attached]
* rpmlint output::
    ldm.i386: E: non-executable-script /usr/share/ldm/ldm-script 0644
  This looks like a script that is intended to start and stop services when
  a user logs into the box.  Does it need to be executable?
  [Not fixed]

* When upstream releases a tarball of this package it will likely be named ldm2
  (judging from the tarball that make dist creates).  Since the main binary is
  named ldm and we're not likely to package ldm1 ever, I think naming this
  package ldm is fine.
* No locales are currently installed but there are some translations available.
  When those are installed, be sure to include them using %{find_lang} so that
  they are properly marked as language files.
* Although this is a graphical application, it does not need a .desktop file
  because it does not run from a desktop session.  Instead it is used to
  start a desktop session.

I'll attach a new spec file in a moment that addresses most of the issues.
Comment 2 Toshio Ernie Kuratomi 2008-01-15 07:58:04 EST
Created attachment 291708 [details]
spec file solving most review issues

This solves all review issues except whether /usr/share/ldm/ldm-script schould
be executable and if so, whether it belongs in /usr/share/ or somewhere else
like /usr/libexec.
Comment 3 Warren Togami 2008-01-16 23:53:16 EST

Built on top of your upstream changes... you made ldm-script and rc.d install
into libexecdir without the trailing /ldm.  Please check that I fixed this properly?
Comment 4 Toshio Ernie Kuratomi 2008-01-17 09:23:30 EST

Looks good.  I changed the README to reflect your changes to libexecdir and
pushed upstream.

Only one thing left to be fixed in the spec file:

 * Need to have checkout instructions for getting the source for revision control:

   For instance::

     # bzr snapshot::
     #   bzr checkout --lightweight -r 791
     #   cd ldm-trunk
     #   ./mkdst --test
     # tarball is ldm-%{version}.tar.bz2

Fix this when you checkin and this package is approved.

Note: I also notice that gcc is throwing several valid warnings.  I'm attaching
a patch for you to review that fixes most of them.  I didn't fix any of the::
  "warning: ignoring return value of ‘write’, declared with attribute

because I'm not sure how you want to deal with those.
Comment 5 Toshio Ernie Kuratomi 2008-01-17 09:25:04 EST
Created attachment 291998 [details]
Fix many warnings issued by gcc.
Comment 6 Warren Togami 2008-02-09 13:52:42 EST
Description of blocker in LDM that needs to be fixed before Fedora 9.
Comment 7 Warren Togami 2008-03-10 01:24:25 EDT
OK well this is in F-9, so closing.

Note You need to log in before you can comment on or make changes to this bug.