Bug 429081
| Summary: | Review Request: perl-DateTime-Format-Oracle - Parse and format Oracle dates and timestamps | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, ppisar, psabata, wfp5p |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/DateTime-Format-Oracle/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-DateTime-Format-Oracle-0.06-8.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-02-02 02:19:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 429080, 430352 | ||
| Bug Blocks: | 411551 | ||
|
Description
Chris Weyl
2008-01-17 06:02:59 UTC
koji build failed http://koji.fedoraproject.org/koji/getfile?taskID=355995&name=build.log any update? Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 672f1496bacf11660fa4001d7ef8cce2 DateTime-Format-Oracle-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/defaults...........ok t/format_datetime....ok t/parse_datetime.....ok All tests successful. Files=3, Tests=35, 1 wallclock secs ( 0.82 cusr + 0.05 csys = 0.87 CPU) + Package perl-DateTime-Format-Oracle-0.03-1.fc9 => Provides: perl(DateTime::Format::Oracle) = 0.03 Requires: perl(Carp) perl(Convert::NLS_DATE_FORMAT) perl(DateTime) perl(DateTime::Format::Builder) perl(strict) APPROVED. New Package CVS Request ======================= Package Name: perl-DateTime-Format-Oracle Short Description: Parse and format Oracle dates and timestamps Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig cvs done. Imported and built for rawhide; the rest following :) Thanks for the review! Package Change Request ====================== Package Name: perl-DateTime-Format-Oracle New Branches: el6 Owners: psabata InitialCC: perl-sig Git done (by process-git-requests). *** Bug 1155268 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: perl-DateTime-Format-Oracle New Branches: epel7 Owners: wfp InitialCC: perl-sig wfp requsted the branch for himself in bug #1155268. Comments from primary maintainers? Primary maintainer is out of order now (vacation). I thought that anybody with approveacls permission is equaled to the primary contact. But nevertheless, I hope wfp can wait till Friday. I don't mind waiting. The Fedora 20 packages builds fine for epel7 so I'm using that for now. I agree with Petr. It shouldn't matter which maintainer acks the change. Anyhow, I'm fine with it. Git done (by process-git-requests). perl-DateTime-Format-Oracle-0.06-8.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-DateTime-Format-Oracle-0.06-8.el7 perl-DateTime-Format-Oracle-0.06-8.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |