Bug 429086

Summary:	Review Request: sonic-visualiser - A program for viewing and exploring audio data
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	hdegoede: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-20 21:54:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	429084, 429085
Bug Blocks:

Description Michel Lind 2008-01-17 06:27:23 UTC

Spec URL: http://salimma.fedorapeople.org/for_review/music/sonic-visualiser.spec
SRPM URL: http://salimma.fedorapeople.org/for_review/music/sonic-visualiser-1.0-1.fc8.src.rpm
Description:
Sonic Visualiser is an application for viewing and analysing the
contents of music audio files.

The aim of Sonic Visualiser is to be the first program you reach for
when want to study a musical recording rather than simply listen to
it.

As well as a number of features designed to make exploring audio data
as revealing and fun as possible, Sonic Visualiser also has powerful
annotation capabilities to help you to describe what you find, and the
ability to run automated annotation and analysis plugins in the Vamp
analysis plugin format – as well as applying standard audio effects.

Comment 1 Hans de Goede 2008-01-27 09:43:54 UTC

Doing a full review of this and bug 429084, please review bug 366841 and 427077
in return.

Comment 2 Hans de Goede 2008-01-27 09:47:08 UTC

Make that:
Doing a full review of this and bug 430307, please review bug 366841 and bug
427077 in return.

As bug 429084 already is being reviewed by someone else :)

Comment 3 Hans de Goede 2008-01-27 10:23:22 UTC

Full review done:

MUST FIX:
---------

* License is wrong, should be GPLv2+
* Icon file should go to /usr/share/icons/hicolor/48x48/apps (per
  freedesktop.org icon standard), you should then also add a: "Requires
  hicolor-icon-theme" for directory ownership and icon cache update scriplets
  as listed here: 
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
* rpmlint says:
  sonic-visualiser.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab:
line 11)

Other then that its fine.

Comment 4 Michel Lind 2008-01-27 15:15:14 UTC

Fixed, thanks:
http://salimma.fedorapeople.org/for_review/music/sonic-visualiser-1.0-2.fc9.src.rpm

Comment 5 Parag AN(पराग) 2008-01-28 07:03:39 UTC

above is not building because of
mkdir -p $RPM_BUILD_ROOT%{_datadir}/pixmaps
install -m 644 -p sv/icons/sv-48x48.png
$RPM_BUILD_ROOT%{_datadir}/icons/hicolor/apps/sonic-visualiser.png

Comment 6 Hans de Goede 2008-01-28 08:47:16 UTC

(In reply to comment #5)
> above is not building because of
> mkdir -p $RPM_BUILD_ROOT%{_datadir}/pixmaps
> install -m 644 -p sv/icons/sv-48x48.png
> $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/apps/sonic-visualiser.png
> 

Also the destination should be:
$RPM_BUILD_ROOT%{_datadir}/icons/hicolor/48x48/apps/sonic-visualiser.png

Notice the 48x48 in the destionation!

Comment 7 Michel Lind 2008-01-28 20:52:59 UTC

Woops, yes. Must be sleeping when I made the change (the files section was fine,
for instance)

Fixed, same URL.

Comment 8 Hans de Goede 2008-01-30 09:54:34 UTC

Looks good now, approved!

Comment 9 Michel Lind 2008-01-30 17:57:02 UTC

Thanks both, for a very thorough review!

New Package CVS Request
=======================
Package Name: sonic-visualiser
Short Description: A program for viewing and exploring audio data
Owners: salimma
Branches: EL-5 F-7 F-8
InitialCC: 
Cvsextras Commits: yes

Comment 10 Kevin Fenzi 2008-01-30 20:33:03 UTC

cvs done.

Comment 11 Michel Lind 2008-02-20 21:54:05 UTC

Update: sonic-visualiser has been in Rawhide for a few days. Holding back on doing F-8 build because of 
a missing dependency in the first version of libfishsound I built, that s-v uses. Waiting until that enters 
stable first.