Spec URL: http://salimma.fedorapeople.org/for_review/music/sonic-visualiser.spec SRPM URL: http://salimma.fedorapeople.org/for_review/music/sonic-visualiser-1.0-1.fc8.src.rpm Description: Sonic Visualiser is an application for viewing and analysing the contents of music audio files. The aim of Sonic Visualiser is to be the first program you reach for when want to study a musical recording rather than simply listen to it. As well as a number of features designed to make exploring audio data as revealing and fun as possible, Sonic Visualiser also has powerful annotation capabilities to help you to describe what you find, and the ability to run automated annotation and analysis plugins in the Vamp analysis plugin format – as well as applying standard audio effects.
Doing a full review of this and bug 429084, please review bug 366841 and 427077 in return.
Make that: Doing a full review of this and bug 430307, please review bug 366841 and bug 427077 in return. As bug 429084 already is being reviewed by someone else :)
Full review done: MUST FIX: --------- * License is wrong, should be GPLv2+ * Icon file should go to /usr/share/icons/hicolor/48x48/apps (per freedesktop.org icon standard), you should then also add a: "Requires hicolor-icon-theme" for directory ownership and icon cache update scriplets as listed here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda * rpmlint says: sonic-visualiser.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 11) Other then that its fine.
Fixed, thanks: http://salimma.fedorapeople.org/for_review/music/sonic-visualiser-1.0-2.fc9.src.rpm
above is not building because of mkdir -p $RPM_BUILD_ROOT%{_datadir}/pixmaps install -m 644 -p sv/icons/sv-48x48.png $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/apps/sonic-visualiser.png
(In reply to comment #5) > above is not building because of > mkdir -p $RPM_BUILD_ROOT%{_datadir}/pixmaps > install -m 644 -p sv/icons/sv-48x48.png > $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/apps/sonic-visualiser.png > Also the destination should be: $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/48x48/apps/sonic-visualiser.png Notice the 48x48 in the destionation!
Woops, yes. Must be sleeping when I made the change (the files section was fine, for instance) Fixed, same URL.
Looks good now, approved!
Thanks both, for a very thorough review! New Package CVS Request ======================= Package Name: sonic-visualiser Short Description: A program for viewing and exploring audio data Owners: salimma Branches: EL-5 F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Update: sonic-visualiser has been in Rawhide for a few days. Holding back on doing F-8 build because of a missing dependency in the first version of libfishsound I built, that s-v uses. Waiting until that enters stable first.