Red Hat Bugzilla – Bug 429084
Review Request: vamp-plugin-sdk - An API for audio analysis and feature extraction plugins
Last modified: 2008-02-13 00:11:09 EST
Spec URL: http://salimma.fedorapeople.org/for_review/music/vamp-plugin-sdk.spec SRPM URL: http://salimma.fedorapeople.org/for_review/music/vamp-plugin-sdk-1.1b-1.fc8.src.rpm Description: Vamp is an API for C and C++ plugins that process sampled audio data to produce descriptive output (measurements or semantic observations).
Can you drop static libraries from -devel package?
koji build failed with log http://koji.fedoraproject.org/koji/getfile?taskID=375623&name=build.log
Fixed build: http://koji.fedoraproject.org/koji/taskinfo?taskID=376090 http://salimma.fedorapeople.org/for_review/music/vamp-plugin-sdk-1.1b-2.fc9.src.rpm I split the static libraries to a separate subpackage, to allow static compilation of applications that use vamp-plugin-sdk (the app I'm packaging, sonic-visualiser, is shipped by upstream in static form, a self-contained binary)
Not sure how this will be allowed as you can see http://fedoraproject.org/wiki/Packaging/Guidelines#head-ed9c4b45be77361033ccbc199bb3d49d02283ba9 static linkage needs FESCO approval.
But I'm not statically linking; I'm giving the opportunity for users of the SDK to statically link (my packaging of sonic-visualiser is dynamically linked). If you 'ls /usr/lib*/*.a' you'll find quite a bunch of them.
ahh. Got it now. Will review this.
I think you better remove static rpm dependency on -devel subpackage. Let -static be independent installation.
(In reply to comment #7) > I think you better remove static rpm dependency on -devel subpackage. Let > -static be independent installation. I agree that when developer want to install -devel and if he want to statically link then he should also get -static. But I think good to make it independent. I leave this upto you. As you have patched Makefile, I think its good to even change all cp commands to preserve timestamp by making them to install using "cp -p" Good to install examples directory as %doc of -devel package.
Agreed on preserving timestamps (thanks for noticing that). Regarding -devel and -static, -devel has the pkgconfig.pc file so static has to pull it as well. I quite like chaining dependencies when they make sense; it allows a user to just 'yum install vamp-plugin-sdk-static' here and have everything working. Will post updated package with the timestamp and %doc changes later today.
http://salimma.fedorapeople.org/for_review/music/vamp-plugin-sdk-1.1b-3.fc9.src.rpm Packaged examples (and added an auto-generated Makefile that builds the example plugins). Also caught hardcoded lib path in the pkgconfig files.
rpmlint gave me => vamp-plugin-sdk.i386: E: non-standard-executable-perm /usr/lib/libvamp-hostsdk.so.2.0.0 0775 vamp-plugin-sdk.i386: E: non-standard-executable-perm /usr/lib/libvamp-sdk.so.1.1.0 0775
Weird, it's 0755 here. I guess I'll switch to using install rather than cp -p.
above review I did based on my local mock setting but koji seems to have silent output on this package now. http://koji.fedoraproject.org/koji/taskinfo?taskID=380186 will review this now.
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url aeda086f10227e6ca473f714ac025807 vamp-plugin-sdk-1.1b.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + static libraries present in -static subpackage. + .pc files present. + -devel and -static subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package vamp-plugin-sdk-1.1b-3.fc9 -> Provides: libvamp-hostsdk.so.2.0.0 libvamp-sdk.so.1.1.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libm.so.6(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libvamp-hostsdk.so.2.0.0 libvamp-sdk.so.1.1.0 rtld(GNU_HASH) + Package vamp-plugin-sdk-devel-1.1b-3.fc9 -> Requires: libvamp-hostsdk.so.2.0.0 libvamp-sdk.so.1.1.0 pkgconfig vamp-plugin-sdk = 1.1b-3.fc9 + Package vamp-plugin-sdk-static-1.1b-3.fc9 -> Requires: vamp-plugin-sdk-devel = 1.1b-3.fc9 + Not a GUI App. APPROVED.
Thanks! New Package CVS Request ======================= Package Name: vamp-plugin-sdk Short Description: An API for audio analysis and feature extraction plugins Owners: salimma Branches: EL-5 F-7 F-8 InitialCC: Cvsextras Commits: yes
vamp-plugin-sdk-1.1b-3.fc8 has been submitted as an update for Fedora 8
vamp-plugin-sdk-1.1b-3.fc7 has been submitted as an update for Fedora 7
Looks like cvs is done here... clearing flag.
vamp-plugin-sdk-1.1b-3.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vamp-plugin-sdk'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-1243
I think you can submit this for stable repo now.
Just pushed, thanks.
vamp-plugin-sdk-1.1b-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
vamp-plugin-sdk-1.1b-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.