Bug 434071

Errors in i386 build.log:

gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
-mtune=generic -fasynchronous-unwind-tables -I.   -c -o devices/yaboot-parser.o
devices/yaboot-parser.c
devices/udev-helper.c: In function 'is_removable_device':
devices/udev-helper.c:321: error: 'PATH_MAX' undeclared (first use in this function)
devices/udev-helper.c:321: error: (Each undeclared identifier is reported only once
devices/udev-helper.c:321: error: for each function it appears in.)
devices/udev-helper.c:321: warning: unused variable 'full_path'
devices/udev-helper.c: In function 'found_new_device':
devices/udev-helper.c:352: error: 'PATH_MAX' undeclared (first use in this function)
devices/udev-helper.c:352: warning: unused variable 'mountpoint'
petitboot.c: In function 'pboot_event_filter':
petitboot.c:795: warning: ignoring return value of 'system', declared with
attribute warn_unused_result
devices/udev-helper.c: In function 'poll_device_plug':
devices/udev-helper.c:402: error: 'INT_MAX' undeclared (first use in this function)
devices/udev-helper.c: In function 'poll_device_unplug':
devices/udev-helper.c:440: error: 'INT_MAX' undeclared (first use in this function)
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -I. -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
-mtune=generic -fasynchronous-unwind-tables -I.   -c -o devices/kboot-parser.o
devices/kboot-parser.c
make: *** [devices/udev-helper.o] Error 1
make: *** Waiting for unfinished jobs....
devices/kboot-parser.c: In function 'parse_option':
devices/kboot-parser.c:132: warning: ignoring return value of 'asprintf',
declared with attribute warn_unused_result
devices/kboot-parser.c:140: warning: ignoring return value of 'asprintf',
declared with attribute warn_unused_result
devices/kboot-parser.c:146: warning: ignoring return value of 'asprintf',
declared with attribute warn_unused_result
devices/kboot-parser.c:154: warning: ignoring return value of 'asprintf',
declared with attribute warn_unused_result
error: Bad exit status from /var/tmp/rpm-tmp.6090 (%build)

Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

*** Bug 440853 has been marked as a duplicate of this bug. ***

This package has Failed to Build From Source for many months.  Per
http://fedoraproject.org/wiki/FTBFS, this package is now proposed for
removal from the distribution.  Please address this FTBFS bug
immediately, or this package will be removed from the distribution
within the next few weeks.

Thank you for your continued contributions to Fedora, and your
commitment to ensuring Fedora packages remain buildable from source
code.

%changelog
* Fri Apr 18 2008 David Woodhouse <dwmw2> - 2.5.0-7
- Fix GCC 4.3 compilation (#440981)

oops, wrong bug; sorry. I'll go look at petitboot now.

Build fix: include <linux/limits.h> in devices/udev-helper.c.
Built in rawhide.
http://koji.fedoraproject.org/koji/taskinfo?taskID=832350

I don't like the fix. Why are we using kernel headers instead of glibc headers?
That's almost always the wrong thing to do.