Bug 434706
Summary: | Review Request: ocaml-type-conv - OCaml base library for type conversion | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-04-04 16:31:08 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 434707 |
Description
Richard W.M. Jones
2008-02-24 18:36:54 UTC
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=482333 make[1]: Entering directory `/builddir/build/BUILD/type-conv-1.3.0/lib' ocamlc -c -I +camlp4 pa_type_conv.mli File "pa_type_conv.mli", line 34, characters 0-23: Unbound module Camlp4.PreCast.Ast make[1]: *** [pa_type_conv.cmi] Error 2 Ick, another missing camlp4... Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-type-conv.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-type-conv-1.3.0-2.fc9.src.rpm * Sat Mar 1 2008 Richard W.M. Jones <rjones> - 1.3.0-2 - Add missing BR for ocaml-camlp4-devel and test build in mock. movk build failed for me. Not sure if its rawhide dependency problems. http://koji.fedoraproject.org/koji/getfile?taskID=483081&name=root.log Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=483525 + rpmlint is NOT silent for SRPM and for RPM. ocaml-type-conv.i386: W: invalid-license LGPLv2+ with exceptions ocaml-type-conv.i386: E: no-binary ocaml-type-conv.i386: E: only-non-binary-in-usr-lib ocaml-type-conv.src: W: invalid-license LGPLv2+ with exceptions ==> Ok to accept as per fixed in bug 434690 and bug 433783 + source files match upstream. 07658454c84d24b07083dea6af2b3e18 type-conv-1.3.0.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Package ocaml-type-conv-1.3.0-2.fc9 => Provides: ocaml(Pa_type_conv) = 432cfbcca727c79fd9a65c602aa4eb34 Requires: ocaml(Arg) = 03e86a4154064ea900dc32c05f53e364 ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3 ocaml(Camlp4) = 1e46a133b8062d1571640f7fa36f32c4 ocaml(Camlp4_config) = cb716b4361f43326c6ad695c7a1bb5c0 ocaml(Camlp4_import) = 0134ca95282ef6821081c0c11802cea0 ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1 ocaml(Filename) = 633a1e7f590ff5e95124293dbef3b476 ocaml(Format) = 35fe566f7a37d8991a5c822bd1463949 ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4 ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4 ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d ocaml(Lexing) = b1793496643444d3762dd42bebe2cfe3 ocaml(List) = da1ce9168f0408ff26158af757456948 ocaml(Map) = dedde7683d54ae7db1eb97cc868dd047 ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Parsing) = 62cca107e4e88af303516459a87c3e9a ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(Queue) = caa3a209bfc63d23a30f573541a88fec ocaml(Set) = 7da14e671a035f12386ace3890018ef3 ocaml(Stream) = 21a833e12efd34ea0c87d8d9da959809 ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28 ocaml(runtime) = 3.10.1 - Not followed ocaml packaging guildelines by packaging *.cmo files SHOULD: 1) Either follow guidelines and remove *.cmo or Specify reason to accept it or as you said in other review (https://bugzilla.redhat.com/show_bug.cgi?id=435293#c2), I will wait till this gets approved as official packaging guidelines. 2) You can use following to silent rpmlint for "no-binary" BuildArch: noarch The .cmo file is the program so not distributing the .cmo file would defeat the purpose of packaging this. I've started a round of discussion on new packaging guidelines to clarify this. See fedora-packaging mailing list. New guidelines are up. APPROVED. New Package CVS Request ======================= Package Name: ocaml-type-conv Short Description: OCaml base library for type conversion Owners: rjones Branches: F-8 InitialCC: rjones Cvsextras Commits: yes cvs done. |