Bug 435090
Summary: | Review Request: Cython - This is a development version of Pyrex, a language for writing Python extension modules. | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Neal Becker <ndbecker2> | ||||
Component: | Package Review | Assignee: | José Matos <jamatos> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review, michel, notting, rdieter, steve.traylen | ||||
Target Milestone: | --- | Flags: | jamatos:
fedora-review+
j: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Cython-0.14.1-3.el6 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-04-15 12:27:16 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Neal Becker
2008-02-27 10:41:28 UTC
Neal I would like to review the package but I can't access your site because it is in a port blocked by the firewall here. Could you please place elsewhere with fedorapeople.org being the logical candidate. :-) OK, I copied to http://nbecker.fedorapeople.org/ Taking the review. Needs work: * Source Cython-0.9.6.13.1.tar.gz is different from upstream (wiki: QAChecklist item 2) using md5sum I get: b84818d4cfcec68e6dfb71187e9f0b4b upstream 3b7bde3b0869b3624cd80fe5cde4e2ed srpm * rpmlint of source RPM: Cython.src: W: mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 1) Cython.src: W: invalid-license PSFL * rpmlint of Cython: Cython.noarch: W: file-not-utf8 /usr/share/doc/Cython-0.9.6.13.1/CHANGES_pyrex.txt Cython.noarch: W: invalid-license PSFL The license should be Python. The mixed use of spaces and tabs is easy to fix and the other warning is just that. :-) * %files According to http://fedoraproject.org/wiki/Packaging/Python /!\ You shouldn't rely on INSTALLED_FILES, as that will not list directories, which will need to be specified in the %files section as well. Using globs in the %files section is safer. * %description You refer Doc/About.html but that file is not packaged. Created attachment 302341 [details]
Spec file patch with some fixes
+* Mon Apr 14 2008 José Matos <jamatos[AT]fc.up.pt> - 0.9.6.13.1-3
+- Remove remaining --record.
+- Add more documentation (Doc and Tools).
+- Add correct entry for egg-info (F9+).
In this I thought it was easier to send a patch. :-) There was a spurious --record left in %install, I have rename the lib dir location following the usual name (it is easier to follow). I have added more documentation, IMHO there is no reason not to include the whole Doc directory. For Tools it would be nice to have the cython-mode.el as a sub-package but clearly it is not required. :-) Regarding the egg-info I see that you still using F-8. :-) Great! Please see: http://nbecker.fedorapeople.org/Cython-0.9.6.13.1-3.fc8.src.rpm (same as your patch) Review for release 3.fc9: * RPM name is OK * Source Cython-0.9.6.13.1.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * License is OK (31 checks have been run) APPROVED New Package CVS Request ======================= Package Name: Cython Short Description: A language for writing Python extension modules Owners: nbecker Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. *** Bug 450455 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: Cython New Branches: el5 el6 Owners: stevetraylen Following the comments in #612776 I'd like to create EPEL branches. Steve. To add a hyperlink Bug 612776 Fine with me. I don't have resources to maintain them though - it's all yours. Git done (by process-git-requests). Cython-0.14.1-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/Cython-0.14.1-3.el5 Cython-0.14.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/Cython-0.14.1-3.el6 Cython-0.14.1-3.el5 has been pushed to the Fedora EPEL 5 stable repository. Cython-0.14.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |