Red Hat Bugzilla – Bug 435090
Review Request: Cython - This is a development version of Pyrex, a language for writing Python extension modules.
Last modified: 2011-04-24 17:59:11 EDT
Spec URL: http://nbecker.dyndns.org:8080/RPM/Cython.spec
SRPM URL: http://nbecker.dyndns.org:8080/RPM/Cython-0.9.6.12-1.fc8.src.rpm
Description: This is a development version of Pyrex, a language
for writing Python extension modules.
rpmlint - 2 small warnings
mock - pass
Neal I would like to review the package but I can't access your site because
it is in a port blocked by the firewall here. Could you please place elsewhere
with fedorapeople.org being the logical candidate. :-)
OK, I copied to http://nbecker.fedorapeople.org/
Taking the review.
* Source Cython-0.9.6.13.1.tar.gz is different from upstream
(wiki: QAChecklist item 2) using md5sum I get:
* rpmlint of source RPM:
Cython.src: W: mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 1)
Cython.src: W: invalid-license PSFL
* rpmlint of Cython:
Cython.noarch: W: file-not-utf8
Cython.noarch: W: invalid-license PSFL
The license should be Python. The mixed use of spaces and tabs is easy to fix
and the other warning is just that. :-)
According to http://fedoraproject.org/wiki/Packaging/Python
/!\ You shouldn't rely on INSTALLED_FILES, as that will not list directories,
which will need to be specified in the %files section as well. Using globs in
the %files section is safer.
You refer Doc/About.html but that file is not packaged.
Created attachment 302341 [details]
Spec file patch with some fixes
+* Mon Apr 14 2008 José Matos <jamatos[AT]fc.up.pt> - 0.9.6.13.1-3
+- Remove remaining --record.
+- Add more documentation (Doc and Tools).
+- Add correct entry for egg-info (F9+).
In this I thought it was easier to send a patch. :-)
There was a spurious --record left in %install, I have rename the lib dir
location following the usual name (it is easier to follow).
I have added more documentation, IMHO there is no reason not to include the
whole Doc directory. For Tools it would be nice to have the cython-mode.el as
a sub-package but clearly it is not required. :-)
Regarding the egg-info I see that you still using F-8. :-)
Great! Please see:
(same as your patch)
Review for release 3.fc9:
* RPM name is OK
* Source Cython-0.9.6.13.1.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* License is OK
(31 checks have been run)
New Package CVS Request
Package Name: Cython
Short Description: A language for writing Python extension modules
Branches: F-7 F-8
Cvsextras Commits: yes
*** Bug 450455 has been marked as a duplicate of this bug. ***
Package Change Request
Package Name: Cython
New Branches: el5 el6
Following the comments in #612776
I'd like to create EPEL branches.
To add a hyperlink Bug 612776
Fine with me. I don't have resources to maintain them though - it's all yours.
Git done (by process-git-requests).
Cython-0.14.1-3.el5 has been submitted as an update for Fedora EPEL 5.
Cython-0.14.1-3.el6 has been submitted as an update for Fedora EPEL 6.
Cython-0.14.1-3.el5 has been pushed to the Fedora EPEL 5 stable repository.
Cython-0.14.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository.