Bug 438354

Summary:	Review Request: python-decorator - Module to simplify usage of decorators
Product:	[Fedora] Fedora	Reporter:	Toshio Ernie Kuratomi <a.badger>
Component:	Package Review	Assignee:	Tim Lauridsen <tim.lauridsen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lmacken, notting
Target Milestone:	---	Flags:	tim.lauridsen: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-04-08 00:29:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	438433

Description Toshio Ernie Kuratomi 2008-03-20 15:04:08 UTC

Spec URL: http://toshio.fedorapeople.org/packages/python-decorator.spec
SRPM URL: http://toshio.fedorapeople.org/packages/python-decorator-2.2.0-1.el5.src.rpm
Description: 
The aim of the decorator module is to simplify the usage of decorators for
the average programmer, and to popularize decorators usage giving examples
of useful decorators, such as memoize, tracing, redirecting_stdout, locked,
etc.  The core of this module is a decorator factory called decorator.

Comment 1 Tim Lauridsen 2008-03-21 09:47:55 UTC

I will do this review.

Comment 2 Tim Lauridsen 2008-03-21 10:00:36 UTC

rpmlint is silent on both RPM & SRPM.

MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* summary and description fine
* correct buildroot
* %{?dist} is used
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime

SHOULD:
* package should build on i386
? package should build in mock
 - I haven't tried, but I don't think it'll be a problem

APPROVED

Comment 3 Toshio Ernie Kuratomi 2008-04-06 05:57:28 UTC

New Package CVS Request
=======================
Package Name: python-decorator
Short Description: Module to simplify usage of decorators
Owners: toshio
Branches: F-8 EL-5 devel
InitialCC: 
Cvsextras Commits: yes

Comment 4 Kevin Fenzi 2008-04-07 22:06:56 UTC

cvs done.

Comment 5 Toshio Ernie Kuratomi 2008-04-08 00:29:41 UTC

Committed and built.