Spec URL: http://toshio.fedorapeople.org/packages/python-decorator.spec SRPM URL: http://toshio.fedorapeople.org/packages/python-decorator-2.2.0-1.el5.src.rpm Description: The aim of the decorator module is to simplify the usage of decorators for the average programmer, and to popularize decorators usage giving examples of useful decorators, such as memoize, tracing, redirecting_stdout, locked, etc. The core of this module is a decorator factory called decorator.
I will do this review.
rpmlint is silent on both RPM & SRPM. MUST: * package is named appropriately * it is legal for Fedora to distribute this * license field matches the actual license. * license is open source-compatible. * specfile name matches %{name} * summary and description fine * correct buildroot * %{?dist} is used * package meets FHS (http://www.pathname.com/fhs/) * changelog format fine * Packager tag not used * Vendor tag not used * Distribution tag not used * License used and not Copyright * Summary tag does not end in a period * specfile is legible * package successfully compiles and builds on at least x86 * make sure lines are <= 80 characters * specfile written in American English * no -doc sub-package necessary * no libraries * no rpath * not a GUI app * no -devel sub-package necessary * macros used appropriately and consistently * no %makeinstall * install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot} * no locale data * split Requires(pre,post) into two separate lines * package not relocatable * package contains code * package owns all directories and files * no %files duplicates * %defattrs present ( %defattr(-, root, root, -)) * %clean present * %doc files do not affect runtime SHOULD: * package should build on i386 ? package should build in mock - I haven't tried, but I don't think it'll be a problem APPROVED
New Package CVS Request ======================= Package Name: python-decorator Short Description: Module to simplify usage of decorators Owners: toshio Branches: F-8 EL-5 devel InitialCC: Cvsextras Commits: yes
cvs done.
Committed and built.