Bug 439731

Summary:	[PATCH] Please update PulseAudio plugin
Product:	[Fedora] Fedora	Reporter:	Lennart Poettering <lpoetter>
Component:	xine-lib	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	belegdol, gauret, kevin, lkundrak, rdieter, shawn.starr, ville.skytta
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	1.1.11.1-2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-04-07 13:08:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lennart Poettering 2008-03-31 02:05:26 UTC

The PulseAudio plugin shipped with xine-lib upstream is a racy mess, please
integrate this patch I just prepared which fixes all issues I am aware of:

http://0pointer.de/public/xine-pulse-rework.patch

I think this is safe for F9 given the bad quality of the old driver. Even if the
new one is not perfect, it's still far better then the current driver.

Changes:
* Remove the awful mess of racyness
* Remove all usleep() loops
* Implement muting properly
* Support surround sound properly
* Implement Pause/Resume
* Clean other things up

I am posting this upstream now too.

Comment 1 Rex Dieter 2008-03-31 12:51:47 UTC

Now that xine-pulse plugin may actually be useful (pending confirmation) :) ,
I'd propose it be packaged separately (from the rest of -extras) similar to
-arts subpkg.

Comment 2 Rex Dieter 2008-03-31 14:02:10 UTC

And, if there are no objections, yes, I'm volunteering to do/help-with the
packaging work to make that happen.

Comment 3 Ville Skyttä 2008-03-31 18:12:01 UTC

Fine with me.

Comment 4 Lennart Poettering 2008-04-01 18:38:01 UTC

Got merged upstream, BTW.

Anyone objects if I do the commit?

Comment 5 Lennart Poettering 2008-04-01 18:38:26 UTC

(of course, assuming the ACLs are properly set...)

Comment 6 Lennart Poettering 2008-04-02 21:07:17 UTC

I updated this patch again: 

http://0pointer.de/public/xine-pulse-rework2.patch

Fixes another limitation of the original driver: unbreaks driver autoprobing.

Comment 7 Kevin Kofler 2008-04-06 07:32:33 UTC

That patch is a 404, do you mean this?
http://0pointer.de/public/xine-pulse-rework-fixup.patch

Comment 8 Lennart Poettering 2008-04-07 12:09:34 UTC

Uh, fixed the URL.

rework+fixup is the same as rework2.

Comment 9 Rex Dieter 2008-04-07 13:08:57 UTC

OK, let's give this a whirl:

* Mon Apr 07 2008 Rex Dieter <rdieter> - 1.1.11.1-2
- pulse-rework2 patch (#439731)
- -pulseaudio subpkg (#439731)

Comment 10 Julian Sikorski 2008-04-07 13:16:07 UTC

Are there any chances for seeing this update in Fedora 8?

Comment 11 Rex Dieter 2008-04-07 13:24:59 UTC

of course, just give us a chance to at least test it a little first. :)

Comment 12 Julian Sikorski 2008-04-07 13:29:42 UTC

OK :)

Comment 13 Rex Dieter 2008-04-07 18:00:44 UTC

*** Bug 345461 has been marked as a duplicate of this bug. ***

Comment 14 Kevin Kofler 2008-04-07 20:56:11 UTC

Rex, I added a small patch to kdebase-runtime which enables the backend in 
Phonon, we can add it to the specfile and build it as soon as you're 
comfortable with doing it. We'll also want kde-settings-pulseaudio to Requires: 
xine-lib-pulseaudio.