Bug 441154

Summary: Missing default face icon
Product: [Fedora] Fedora Reporter: Sebastian Vahl <fedora>
Component: kdebase-workspaceAssignee: Kevin Kofler <kevin>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: kevin, ltinkl, rdieter, than
Target Milestone: ---Keywords: EasyFix
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 4.0.3-7.fc9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-04-07 16:30:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 441167    

Description Sebastian Vahl 2008-04-06 21:33:31 UTC
Description of problem:
In kdebase3 we use a symbolic link to define a default face icon:

# own %{_datadir}/apps/kdm/faces
mkdir -p %{buildroot}%{_datadir}/apps/kdm/faces
pushd %{buildroot}%{_datadir}/apps/kdm/faces
ln -sf ../pics/users/default1.png .default.face.icon
popd

kdebase4 is missing this symbolic link. So if we ever have a theme with a user 
list, it would be good to have a default face icon for all users.

Comment 1 Kevin Kofler 2008-04-07 12:39:21 UTC
This file should still be there, only it's %{_kde4_appsdir} now instead 
of %{_datadir}/apps.

Comment 2 Kevin Kofler 2008-04-07 12:40:41 UTC
Oh, actually you mean the symbolic link itself is missing. That's easy to add.

Comment 3 Sebastian Vahl 2008-04-07 14:18:32 UTC
(In reply to comment #2)
> Oh, actually you mean the symbolic link itself is missing. That's easy to 
add.

Indeed. I think we've only missed to also add this from kdebase.spec to 
kdebase-workspace.spec. (I've really forgotten about that when packaging 
kdebase-workspace)



Comment 4 Kevin Kofler 2008-04-07 14:20:09 UTC
I'm going to fix this.

Comment 5 Rex Dieter 2008-04-07 14:23:13 UTC
could also be added to kde-settings (so we don't force a rebuild of all of
kdebase-workspace).  Has the added benefit of allowing sites to "theme" their
face icons (by providing their own kde-settings).

Comment 6 Kevin Kofler 2008-04-07 14:32:45 UTC
Well, the icons are in kdebase-workspace, so we'd either leave a dangling 
symlink in kde-settings or have to require kdebase-workspace from kde-settings.

Comment 7 Than Ngo 2008-04-07 14:44:58 UTC
we have to avoid dangling symlink as we can. I'm against dangling symlink in 
kde-settings

Comment 8 Rex Dieter 2008-04-07 14:52:50 UTC
imo, dangling symlink would be harmless.  the face icons are only useful when/if
kdebase-workspace is installed anyway.

Shrug, like I said in irc, either way works. :)