Bug 441154 - Missing default face icon
Missing default face icon
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: kdebase-workspace (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: Kevin Kofler
Fedora Extras Quality Assurance
: EasyFix
Depends On:
Blocks: 441167
  Show dependency treegraph
 
Reported: 2008-04-06 17:33 EDT by Sebastian Vahl
Modified: 2008-04-07 12:30 EDT (History)
4 users (show)

See Also:
Fixed In Version: 4.0.3-7.fc9
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-04-07 12:30:32 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Sebastian Vahl 2008-04-06 17:33:31 EDT
Description of problem:
In kdebase3 we use a symbolic link to define a default face icon:

# own %{_datadir}/apps/kdm/faces
mkdir -p %{buildroot}%{_datadir}/apps/kdm/faces
pushd %{buildroot}%{_datadir}/apps/kdm/faces
ln -sf ../pics/users/default1.png .default.face.icon
popd

kdebase4 is missing this symbolic link. So if we ever have a theme with a user 
list, it would be good to have a default face icon for all users.
Comment 1 Kevin Kofler 2008-04-07 08:39:21 EDT
This file should still be there, only it's %{_kde4_appsdir} now instead 
of %{_datadir}/apps.
Comment 2 Kevin Kofler 2008-04-07 08:40:41 EDT
Oh, actually you mean the symbolic link itself is missing. That's easy to add.
Comment 3 Sebastian Vahl 2008-04-07 10:18:32 EDT
(In reply to comment #2)
> Oh, actually you mean the symbolic link itself is missing. That's easy to 
add.

Indeed. I think we've only missed to also add this from kdebase.spec to 
kdebase-workspace.spec. (I've really forgotten about that when packaging 
kdebase-workspace)

Comment 4 Kevin Kofler 2008-04-07 10:20:09 EDT
I'm going to fix this.
Comment 5 Rex Dieter 2008-04-07 10:23:13 EDT
could also be added to kde-settings (so we don't force a rebuild of all of
kdebase-workspace).  Has the added benefit of allowing sites to "theme" their
face icons (by providing their own kde-settings).
Comment 6 Kevin Kofler 2008-04-07 10:32:45 EDT
Well, the icons are in kdebase-workspace, so we'd either leave a dangling 
symlink in kde-settings or have to require kdebase-workspace from kde-settings.
Comment 7 Ngo Than 2008-04-07 10:44:58 EDT
we have to avoid dangling symlink as we can. I'm against dangling symlink in 
kde-settings
Comment 8 Rex Dieter 2008-04-07 10:52:50 EDT
imo, dangling symlink would be harmless.  the face icons are only useful when/if
kdebase-workspace is installed anyway.

Shrug, like I said in irc, either way works. :)

Note You need to log in before you can comment on or make changes to this bug.