Bug 442462
| Summary: | Review Request: e_dbus - Wrappers around dbus for EFL based applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Shevchuk <stlwrt> |
| Component: | Package Review | Assignee: | Patrice Dumas <pertusus> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, pertusus |
| Target Milestone: | --- | Flags: | pertusus:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-05-17 22:14:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 442353 | ||
| Bug Blocks: | |||
|
Description
Pavel Shevchuk
2008-04-14 21:45:56 UTC
* Sun May 04 2008 Pavel "Stalwart" Shevchuk <stlwrt> - 0.1.0.042-2 - Fixed typo in E_Nm.h, fix committed upstream - Added missing dependencies to e_dbus-devel - Fixed timestamp of source tarball - Preserve timestamps of installed files New spec: http://rpm.scwlab.com/e_dbus-goes-rawhide/e_dbus.spec New SRPM: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-2.fc9.x86_64/ e_dbus-0.1.0.042-2.fc9.src.rpm Built RPMs: http://rpm.scwlab.com/fedora/e/9/ Same than efreet, are the programs really meant to be installed? Also enm.pc links against enotify and not -lenm. [stalwart@delta e_dbus]$ diff enm.pc enotify.pc
7c7
< Description: Network Manager convenience library
---
> Description: Notification convenience library
enm.pc also has line:
Name: enotify
I guess developer was abusing copypaste-fu technique.
NetworkManager part of e_dbus is yet to reach usable state, and development is
inactive because NM 0.7 API may change.
I don't see this bug as showstopper since there is no E-frontend for NM yet
(In reply to comment #4) > I don't see this bug as showstopper since there is no E-frontend for NM yet Agreed. Also I noticed a missing pkgconfig Requires for the devel package. enm.pc bug is now fixed upstream: http://enlightenment.org/viewvc/e17/libs/e_dbus/enm.pc.in?r1=1.1&r2=1.2 I will patch that with sed expression before uploading spec to cvs. Need for binaries is yet to be clarified. Missing pkgconfig will be fixed too. * Sat May 17 2008 Pavel "Stalwart" Shevchuk <stlwrt> - 0.1.0.042-3 - Fixed pkgconfig missing from buildrequires and requires of e_dbus-devel - Removed unneeded test binaries - Fixed copypaste abuse in enm.pc.in, patch upstreamed New spec: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-3.fc9.x86_64/ e_dbus.spec New SRPM: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-3.fc9.x86_64/ e_dbus-0.1.0.042-3.fc9.src.rpm x86_64 RPMs: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-3.fc9.x86_64/ * rpmlint warning can be ignored e_dbus-devel.i386: W: no-documentation * follow packaging guidelines * pseudo-MIT license included * match upstream cf5092e177d94263be396875d3bfccaa e_dbus-0.1.0.042.tar.bz2 * %files section right * lib correctly packaged The chrpath on binaries that are then removed is not useful, but not harmful either. APPROVED Also, in the future, please check from time to time if %configure --disable-rpath --disable-static works to avoid unneeded rpath. New Package CVS Request ======================= Package Name: e_dbus Short Description: Wrappers around dbus for EFL based applications Owners: stalwart Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes cvs done. Done. Thanks to everyone! |