Bug 442462 - Review Request: e_dbus - Wrappers around dbus for EFL based applications
Summary: Review Request: e_dbus - Wrappers around dbus for EFL based applications
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 442353
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-14 21:45 UTC by Pavel Shevchuk
Modified: 2008-05-17 22:14 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-05-17 22:14:44 UTC
Type: ---
Embargoed:
pertusus: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Pavel Shevchuk 2008-04-14 21:45:56 UTC
Spec URL: http://rpm.scwlab.com/e_dbus-goes-rawhide/e_dbus.spec
SRPM URL: http://rpm.scwlab.com/e_dbus-goes-rawhide/e_dbus-0.1.0.042-1.fc9.src.rpm
RPMs for i386 and x86_64 built in mock: http://rpm.scwlab.com/e_dbus-goes-rawhide/

Description:
Basic convenience wrappers around dbus to ease integrating dbus with EFL based
applications.

RPMLint displays warning about absent doc, but there are none yet, this is first release of e_dbus.
License is a bit customized, but Tom "spot" Callawayin from fedora-legal-list said it's MIT ( https://www.redhat.com/archives/fedora-legal-list/2008-April/msg00020.html )

Comment 1 Pavel Shevchuk 2008-05-04 03:58:48 UTC
* Sun May 04 2008 Pavel "Stalwart" Shevchuk <stlwrt> - 0.1.0.042-2
- Fixed typo in E_Nm.h, fix committed upstream
- Added missing dependencies to e_dbus-devel
- Fixed timestamp of source tarball
- Preserve timestamps of installed files

New spec: http://rpm.scwlab.com/e_dbus-goes-rawhide/e_dbus.spec
New SRPM: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-2.fc9.x86_64/
e_dbus-0.1.0.042-2.fc9.src.rpm
Built RPMs: http://rpm.scwlab.com/fedora/e/9/

Comment 2 Patrice Dumas 2008-05-15 20:47:45 UTC
Same than efreet, are the programs really meant to be installed?

Comment 3 Patrice Dumas 2008-05-15 20:58:55 UTC
Also enm.pc links against enotify and not -lenm.

Comment 4 Pavel Shevchuk 2008-05-15 21:50:06 UTC
[stalwart@delta e_dbus]$ diff enm.pc enotify.pc
7c7
< Description: Network Manager convenience library
---
> Description: Notification convenience library

enm.pc also has line:
Name: enotify

I guess developer was abusing copypaste-fu technique. 

NetworkManager part of e_dbus is yet to reach usable state, and development is 
inactive because NM 0.7 API may change.

I don't see this bug as showstopper since there is no E-frontend for NM yet

Comment 5 Patrice Dumas 2008-05-16 13:01:37 UTC
(In reply to comment #4)
> I don't see this bug as showstopper since there is no E-frontend for NM yet

Agreed.

Also I noticed a missing pkgconfig Requires for the devel package.

Comment 6 Pavel Shevchuk 2008-05-16 13:54:16 UTC
enm.pc bug is now fixed upstream:
http://enlightenment.org/viewvc/e17/libs/e_dbus/enm.pc.in?r1=1.1&r2=1.2
I will patch that with sed expression before uploading spec to cvs.

Need for binaries is yet to be clarified.

Missing pkgconfig will be fixed too.

Comment 7 Pavel Shevchuk 2008-05-16 23:49:23 UTC
* Sat May 17 2008 Pavel "Stalwart" Shevchuk <stlwrt> - 0.1.0.042-3
- Fixed pkgconfig missing from buildrequires and requires of e_dbus-devel
- Removed unneeded test binaries
- Fixed copypaste abuse in enm.pc.in, patch upstreamed

New spec: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-3.fc9.x86_64/
e_dbus.spec
New SRPM: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-3.fc9.x86_64/
e_dbus-0.1.0.042-3.fc9.src.rpm
x86_64 RPMs: http://rpm.scwlab.com/fedora/e/9/e_dbus-0.1.0.042-3.fc9.x86_64/

Comment 8 Patrice Dumas 2008-05-17 08:47:44 UTC
* rpmlint warning can be ignored
e_dbus-devel.i386: W: no-documentation
* follow packaging guidelines
* pseudo-MIT license included
* match upstream
cf5092e177d94263be396875d3bfccaa  e_dbus-0.1.0.042.tar.bz2
* %files section right
* lib correctly packaged

The chrpath on binaries that are then removed is not useful, but 
not harmful either.

APPROVED


Also, in the future, please check from time to time if 
%configure --disable-rpath --disable-static
works to avoid unneeded rpath.

Comment 9 Pavel Shevchuk 2008-05-17 10:04:32 UTC
New Package CVS Request
=======================
Package Name: e_dbus
Short Description: Wrappers around dbus for EFL based applications
Owners: stalwart
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

Comment 10 Kevin Fenzi 2008-05-17 20:31:15 UTC
cvs done. 

Comment 11 Pavel Shevchuk 2008-05-17 22:14:44 UTC
Done. Thanks to everyone!


Note You need to log in before you can comment on or make changes to this bug.