Bug 444426
Summary: | Review Request: gabedit - GUI for computational chemistry | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-05-30 21:09:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dominik 'Rathann' Mierzejewski
2008-04-28 11:27:11 UTC
For 2.1.4-1: * dist tag - Please consider to use %?dist tag. http://fedoraproject.org/wiki/Packaging/DistTag * License - The license of this package is "MIT". * SourceURL - For sourceforge hosted sources, please refer to the section "Sourceforge.net" of http://fedoraproject.org/wiki/Packaging/SourceURL * Parallel make - Please use %{?_smp_mflags} for the platform where _smp_mflags is not set. * rpmlint issues: --------------------------------------------------------------- gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createTPLfile gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createmmfile gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/addInclude gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/addVirgul gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/createH gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createTPLfile gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createmmfile gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/addInclude gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/addVirgul gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/createH gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/InnosSetupScriptWin32/Gabedit210.iss gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/InnosSetupScriptWin32/Gabedit211.iss gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/Others/Gabedit206.iss gabedit.i386: E: wrong-script-interpreter /usr/share/doc/gabedit-2.1.4/utils/Others/gabeditRunGamess.csh "./csh" ----------------------------------------------------------------- Summary: - Please remove all pre-built arch-dependent files under %_docdir - Check if Gabedit21?.iss can be converted into UTF-8 (not a blocker) - Fix the shebang of gabeditRunGamess.csh By the way I would appreciate it if you would review my review request (bug 444933) ping? Sorry, I had serious problems with email for my domain for the last week or so. http://rathann.fedorapeople.org/review/gabedit.spec http://rathann.fedorapeople.org/review/gabedit-2.1.4-2.src.rpm Fixed all issues. Okay. -------------------------------------------------------------------- This package (gabedit) is APPROVED by me -------------------------------------------------------------------- ping again? New Package CVS Request ======================= Package Name: gabedit Short Description: GUI for computational chemistry Owners: rathann Branches: F-8 F-9 EL-5 Cvsextras Commits: yes cvs done. Imported and built for devel and F-9, others will follow. Thank you. |