Hide Forgot
Spec URL: http://rathann.fedorapeople.org/review/gabedit.spec SRPM URL: http://rathann.fedorapeople.org/review/gabedit-2.1.4-1.src.rpm Description: Gabedit is a Graphical User Interface to Gamess-US, Gaussian, Molcas, Molpro and MPQC computational chemistry packages. Gabedit includes graphical facilities for generating keywords and options, molecule specifications and their input sections for even the most advanced calculation types. Gabedit includes an advanced Molecule Builder. You can use it to rapidly sketch in molecules and examine them in three dimensions. You can build molecules by atom, ring, group, amino acid and nucleoside. You can also read geometry from a file. Most major molecular file formats are supported.
For 2.1.4-1: * dist tag - Please consider to use %?dist tag. http://fedoraproject.org/wiki/Packaging/DistTag * License - The license of this package is "MIT". * SourceURL - For sourceforge hosted sources, please refer to the section "Sourceforge.net" of http://fedoraproject.org/wiki/Packaging/SourceURL * Parallel make - Please use %{?_smp_mflags} for the platform where _smp_mflags is not set. * rpmlint issues: --------------------------------------------------------------- gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createTPLfile gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createmmfile gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/addInclude gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/addVirgul gabedit.i386: E: arch-dependent-file-in-usr-share /usr/share/doc/gabedit-2.1.4/utils/Others/createH gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createTPLfile gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/MolecularMechanics/createmmfile gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/addInclude gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/addVirgul gabedit.i386: W: unstripped-binary-or-object /usr/share/doc/gabedit-2.1.4/utils/Others/createH gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/InnosSetupScriptWin32/Gabedit210.iss gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/InnosSetupScriptWin32/Gabedit211.iss gabedit.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/gabedit-2.1.4/utils/Others/Gabedit206.iss gabedit.i386: E: wrong-script-interpreter /usr/share/doc/gabedit-2.1.4/utils/Others/gabeditRunGamess.csh "./csh" ----------------------------------------------------------------- Summary: - Please remove all pre-built arch-dependent files under %_docdir - Check if Gabedit21?.iss can be converted into UTF-8 (not a blocker) - Fix the shebang of gabeditRunGamess.csh By the way I would appreciate it if you would review my review request (bug 444933)
ping?
Sorry, I had serious problems with email for my domain for the last week or so. http://rathann.fedorapeople.org/review/gabedit.spec http://rathann.fedorapeople.org/review/gabedit-2.1.4-2.src.rpm Fixed all issues.
Okay. -------------------------------------------------------------------- This package (gabedit) is APPROVED by me --------------------------------------------------------------------
ping again?
New Package CVS Request ======================= Package Name: gabedit Short Description: GUI for computational chemistry Owners: rathann Branches: F-8 F-9 EL-5 Cvsextras Commits: yes
cvs done.
Imported and built for devel and F-9, others will follow. Thank you.