Bug 444428
| Summary: | Review Request: ocaml-cmigrep - Search OCaml compiled interface (cmi) files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, j, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://homepage.mac.com/letaris/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-08-26 10:59:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 450551 | ||
| Bug Blocks: | |||
|
Description
Richard W.M. Jones
2008-04-28 11:31:56 UTC
Some example usages:
$ cmigrep -c SO_ Unix
SO_DEBUG (* socket_bool_option *)
SO_BROADCAST (* socket_bool_option *)
SO_REUSEADDR (* socket_bool_option *)
SO_KEEPALIVE (* socket_bool_option *)
SO_DONTROUTE (* socket_bool_option *)
SO_OOBINLINE (* socket_bool_option *)
SO_ACCEPTCONN (* socket_bool_option *)
SO_SNDBUF (* socket_int_option *)
SO_RCVBUF (* socket_int_option *)
SO_ERROR (* socket_int_option *)
SO_TYPE (* socket_int_option *)
SO_RCVLOWAT (* socket_int_option *)
SO_SNDLOWAT (* socket_int_option *)
SO_LINGER (* socket_optint_option *)
SO_RCVTIMEO (* socket_float_option *)
SO_SNDTIMEO (* socket_float_option *)
$ cmigrep -a '.*map.*' List
val map : ('a -> 'b) -> 'a list -> 'b list
val rev_map : ('a -> 'b) -> 'a list -> 'b list
val map2 : ('a -> 'b -> 'c) -> 'a list -> 'b list -> 'c list
val rev_map2 : ('a -> 'b -> 'c) -> 'a list -> 'b list -> 'c list
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=585565 Breaks on ppc64 at the moment because we need to add the ppc64 build patch. This does not seem to be buildable yet outside of koji; ocaml 3.10.2 doesn't seem to exist anywhere. Yes, let's wait for Rawhide on this one. Well, I can build it now, but this rpmlint complaint confuses me: ocaml-cmigrep.x86_64: W: executable-stack /usr/bin/cmigrep I don't recall seeing this with ocaml executables in the past. It might be new with recent versions of rpmlint, but I'm not sure. Bug filed: bug 450551 I've verified that this warning can be removed. However you need to rebuild ocaml (3.10.2-4), ocaml-findlib and ocaml-pcre, then cmigrep, because any object file which wasn't built with the non-executable-stack patch 'infects' the resulting binary. Given that, it's probably worth just ignoring the warning for now. $ rpmlint /home/rjones/rpmbuild/SRPMS/ocaml-cmigrep-1.5-2.fc10.src.rpm /home/rjones/rpmbuild/RPMS/x86_64/ocaml-cmigrep-1.5-2.fc10.x86_64.rpm ocaml-cmigrep.src:66: W: configure-without-libdir-spec 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Here's a new package which also fixes the ppc64 build problem. Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-cmigrep.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-cmigrep-1.5-2.fc10.src.rpm Description: Search OCaml compiled interface (cmi) files * Mon Jun 9 2008 Richard W.M. Jones <rjones> - 1.5-2 - Include ppc64 compiler patch. - Include MAP_32BITS compiler patch. - Include no-executable-stack compiler patch. - Rebuild for OCaml 3.10.2-4 (https://bugzilla.redhat.com/show_bug.cgi?id=444428#c5) I guess selinux will probably become annoyed by the executable stack, but as long as the package isn't broken in general I don't see a need to wait until everything rebuilds. That hasn't happened so far, so I won't wait any longer. I don't think it's particularly pretty to have to include the entire compiler source, but I've had to do the same thing and I don't see an alternative other than waiting for the one you mention in the spec to happen. Besides, there really isn't much to this package, just a lot of build time for one file. You should probably include the COPYING file as %doc as well. That's really the only nit I see to pick. * source files match upstream: e420d4ad1ebf062bb4d02028fadccd11a6c5cf7ddde159ebb607f2fefa4ea989 cmigrep-1.5.tar.bz2 3755a32da1a7490d47fff7838c12c754d3fcfe69d7c9ff2358704259dc477c58 ocaml-3.10.2.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: ocaml-cmigrep = 1.5-2.fc10 = libpcre.so.0()(64bit) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED Since I note that you're around currently, I thought I'd ask what was happening with this package since it's been a couple of months. What happened is I stupidly forgot about it. Thanks (yet again!) for your work. I'll file a CVS request now, although I don't expect anything to happen for quite a while because of the continuing Fedora infrastructure problems ... New Package CVS Request ======================= Package Name: ocaml-cmigrep Short Description: Search OCaml compiled interface (cmi) files Owners: rjones Branches: F-9 InitialCC: rjones cvs done. F-10: http://koji.fedoraproject.org/koji/taskinfo?taskID=786405 F-9: http://koji.fedoraproject.org/koji/taskinfo?taskID=786424 https://admin.fedoraproject.org/updates/ocaml-cmigrep-1.5-2.fc9.2 Done, thanks everyone for your help. |