Bug 444428 - Review Request: ocaml-cmigrep - Search OCaml compiled interface (cmi) files
Summary: Review Request: ocaml-cmigrep - Search OCaml compiled interface (cmi) files
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL: http://homepage.mac.com/letaris/
Depends On: 450551
TreeView+ depends on / blocked
Reported: 2008-04-28 11:31 UTC by Richard W.M. Jones
Modified: 2008-08-26 10:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-08-26 10:59:58 UTC
Type: ---
j: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Richard W.M. Jones 2008-04-28 11:31:56 UTC
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-cmigrep.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-cmigrep-1.5-1.fc9.src.rpm
Description: Search OCaml compiled interface (cmi) files

Quite a complex build process to end up with just a single executable!
However it's a very useful executable, allowing you to grep inside
OCaml *.cmi files.  I didn't yet package up the emacs extension.

  ocaml-cmigrep.src:58: E: configure-without-libdir-spec
  (OK because it's not autoconf-generated configure)


Requires & provides are pretty ordinary because this is just
a single binary.
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(CompressedFileNames) <= 3.0.4-1
  ocaml-cmigrep = 1.5-1.fc9

Comment 1 Richard W.M. Jones 2008-04-28 11:33:47 UTC
Some example usages:

$ cmigrep -c SO_ Unix
SO_DEBUG (* socket_bool_option *)
SO_BROADCAST (* socket_bool_option *)
SO_REUSEADDR (* socket_bool_option *)
SO_KEEPALIVE (* socket_bool_option *)
SO_DONTROUTE (* socket_bool_option *)
SO_OOBINLINE (* socket_bool_option *)
SO_ACCEPTCONN (* socket_bool_option *)
SO_SNDBUF (* socket_int_option *)
SO_RCVBUF (* socket_int_option *)
SO_ERROR (* socket_int_option *)
SO_TYPE (* socket_int_option *)
SO_RCVLOWAT (* socket_int_option *)
SO_SNDLOWAT (* socket_int_option *)
SO_LINGER (* socket_optint_option *)
SO_RCVTIMEO (* socket_float_option *)
SO_SNDTIMEO (* socket_float_option *)

$ cmigrep -a '.*map.*' List
val map : ('a -> 'b) -> 'a list -> 'b list
val rev_map : ('a -> 'b) -> 'a list -> 'b list
val map2 : ('a -> 'b -> 'c) -> 'a list -> 'b list -> 'c list
val rev_map2 : ('a -> 'b -> 'c) -> 'a list -> 'b list -> 'c list

Comment 2 Richard W.M. Jones 2008-04-28 11:54:13 UTC
Koji build:

Breaks on ppc64 at the moment because we need to add the ppc64
build patch.

Comment 3 Jason Tibbitts 2008-05-11 02:16:08 UTC
This does not seem to be buildable yet outside of koji; ocaml 3.10.2 doesn't
seem to exist anywhere.

Comment 4 Richard W.M. Jones 2008-05-12 10:53:58 UTC
Yes, let's wait for Rawhide on this one.

Comment 5 Jason Tibbitts 2008-06-05 01:16:48 UTC
Well, I can build it now, but this rpmlint complaint confuses me:
  ocaml-cmigrep.x86_64: W: executable-stack /usr/bin/cmigrep
I don't recall seeing this with ocaml executables in the past.  It might be new
with recent versions of rpmlint, but I'm not sure.

Comment 6 Richard W.M. Jones 2008-06-09 15:26:26 UTC
Bug filed: bug 450551

Comment 7 Richard W.M. Jones 2008-06-09 18:39:27 UTC
I've verified that this warning can be removed.  However you need to
rebuild ocaml (3.10.2-4), ocaml-findlib and ocaml-pcre, then cmigrep,
because any object file which wasn't built with the non-executable-stack
patch 'infects' the resulting binary.  Given that, it's probably worth just
ignoring the warning for now.

$ rpmlint /home/rjones/rpmbuild/SRPMS/ocaml-cmigrep-1.5-2.fc10.src.rpm 
ocaml-cmigrep.src:66: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Here's a new package which also fixes the ppc64 build problem.

Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-cmigrep.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-cmigrep-1.5-2.fc10.src.rpm
Description: Search OCaml compiled interface (cmi) files

* Mon Jun  9 2008 Richard W.M. Jones <rjones@redhat.com> - 1.5-2
- Include ppc64 compiler patch.
- Include MAP_32BITS compiler patch.
- Include no-executable-stack compiler patch.
- Rebuild for OCaml 3.10.2-4

Comment 8 Jason Tibbitts 2008-06-18 22:59:02 UTC
I guess selinux will probably become annoyed by the executable stack, but as
long as the package isn't broken in general I don't see a need to wait until
everything rebuilds.  That hasn't happened so far, so I won't wait any longer.

I don't think it's particularly pretty to have to include the entire compiler
source, but I've had to do the same thing and I don't see an alternative other
than waiting for the one you mention in the spec to happen.

Besides, there really isn't much to this package, just a lot of build time for
one file.

You should probably include the COPYING file as %doc as well.  That's really the
only nit I see to pick.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   ocaml-cmigrep = 1.5-2.fc10

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


Comment 9 Jason Tibbitts 2008-08-20 20:57:40 UTC
Since I note that you're around currently, I thought I'd ask what was happening with this package since it's been a couple of months.

Comment 10 Richard W.M. Jones 2008-08-21 12:20:58 UTC
What happened is I stupidly forgot about it.  Thanks (yet again!) for your
work.  I'll file a CVS request now, although I don't expect anything to
happen for quite a while because of the continuing Fedora infrastructure
problems ...

Comment 11 Richard W.M. Jones 2008-08-21 12:28:03 UTC
New Package CVS Request
Package Name: ocaml-cmigrep
Short Description: Search OCaml compiled interface (cmi) files
Owners: rjones
Branches: F-9
InitialCC: rjones

Comment 12 Kevin Fenzi 2008-08-25 19:56:40 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.