Bug 446984

Summary:	Review Request: emotion - an Evas smart-object library providing video capabilities
Product:	[Fedora] Fedora	Reporter:	Pavel Shevchuk <stlwrt>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-05-20 20:24:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Shevchuk 2008-05-16 20:23:01 UTC

Spec URL: http://rpm.scwlab.com/fedora/e/9/emotion-0.1.0.042-1.fc9.x86_64/emotion.spec
SRPM URL: http://rpm.scwlab.com/fedora/e/9/emotion-0.1.0.042-1.fc9.x86_64/emotion-0.1.0.042-1.fc9.src.rpm
x86_64 RPMs: http://rpm.scwlab.com/fedora/e/9/emotion-0.1.0.042-1.fc9.x86_64/

Description:
Emotion is an Evas smart-object library providing video capabilities. Emotion
leverages xine-lib or GStreamer and integrates seamlessly with the rest of the
EFL.

With Emotion it's unbelievably easy to add video to your application, and by
leveraging the rest of the EFL to build more powerful video players than seen
anywhere else.


Documentation is absent upstream, next snapshot tarball will include it.

Test player is removed because it's aimed for rendering backend testing, it's more like test-suite. Emotion-powered media center application - Rage - will be packaged soon.

Xine and GStreamer backends aren't split out because atm none of backends covers all features provided by Emotion API.

Comment 1 Rex Dieter 2008-05-20 14:44:12 UTC

sources: ok
123c043d02f4da22fb36eede930a44e5  emotion-0.1.0.042.tar.bz2

scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=620064

one thing I see immediately:
1.  Please document the need for using chrpath, ie, why use this instead of 
other means of removing rpath.

Comment 2 Rex Dieter 2008-05-20 14:59:09 UTC

2.  SHOULD omit this from description, which seems like useless evangelizing 
to me:
"With Emotion it's unbelievably easy to add video to your application, and by
leveraging the rest of the EFL to build more powerful video players than seen
anywhere else."

$ rpmlint *.rpm
emotion-devel.x86_64: W: no-documentation
mostly harmless.

otherwise:
naming: ok
license: ok
scriptlets: ok

APPROVED.  I'll leave items 1,2 for you to address as you see fit after 
import.

Comment 3 Pavel Shevchuk 2008-05-20 15:03:40 UTC

1. I used chrpath for first e-packages because of all tried methods this was
easiest and did work. I use it in all e-packages for consistency now. May change
method in future, maybe even fix this upstream =)

2. No problem, will fix.

Comment 4 Pavel Shevchuk 2008-05-20 15:06:13 UTC

New Package CVS Request
=======================
Package Name: ecore
Short Description: Event/X abstraction layer
Owners: stalwart
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

Comment 5 Pavel Shevchuk 2008-05-20 15:07:15 UTC

Ouch, misclicked =\
Real request:


New Package CVS Request
=======================
Package Name: emotion
Short Description: An Evas smart-object library providing video capabilities
Owners: stalwart
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-05-20 16:10:44 UTC

cvs done.

Comment 7 Pavel Shevchuk 2008-05-20 20:24:32 UTC

Koji completed building imported pkg, description fixed after Rex's suggestion. 
Thanks Rex and Kevin!