Bug 446984 - Review Request: emotion - an Evas smart-object library providing video capabilities
Review Request: emotion - an Evas smart-object library providing video capabi...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Rex Dieter
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-16 16:23 EDT by Pavel Shevchuk
Modified: 2008-05-20 16:24 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-05-20 16:24:59 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rdieter: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Pavel Shevchuk 2008-05-16 16:23:01 EDT
Spec URL: http://rpm.scwlab.com/fedora/e/9/emotion-0.1.0.042-1.fc9.x86_64/emotion.spec
SRPM URL: http://rpm.scwlab.com/fedora/e/9/emotion-0.1.0.042-1.fc9.x86_64/emotion-0.1.0.042-1.fc9.src.rpm
x86_64 RPMs: http://rpm.scwlab.com/fedora/e/9/emotion-0.1.0.042-1.fc9.x86_64/

Description:
Emotion is an Evas smart-object library providing video capabilities. Emotion
leverages xine-lib or GStreamer and integrates seamlessly with the rest of the
EFL.

With Emotion it's unbelievably easy to add video to your application, and by
leveraging the rest of the EFL to build more powerful video players than seen
anywhere else.


Documentation is absent upstream, next snapshot tarball will include it.

Test player is removed because it's aimed for rendering backend testing, it's more like test-suite. Emotion-powered media center application - Rage - will be packaged soon.

Xine and GStreamer backends aren't split out because atm none of backends covers all features provided by Emotion API.
Comment 1 Rex Dieter 2008-05-20 10:44:12 EDT
sources: ok
123c043d02f4da22fb36eede930a44e5  emotion-0.1.0.042.tar.bz2

scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=620064

one thing I see immediately:
1.  Please document the need for using chrpath, ie, why use this instead of 
other means of removing rpath.
Comment 2 Rex Dieter 2008-05-20 10:59:09 EDT
2.  SHOULD omit this from description, which seems like useless evangelizing 
to me:
"With Emotion it's unbelievably easy to add video to your application, and by
leveraging the rest of the EFL to build more powerful video players than seen
anywhere else."

$ rpmlint *.rpm
emotion-devel.x86_64: W: no-documentation
mostly harmless.

otherwise:
naming: ok
license: ok
scriptlets: ok

APPROVED.  I'll leave items 1,2 for you to address as you see fit after 
import.
Comment 3 Pavel Shevchuk 2008-05-20 11:03:40 EDT
1. I used chrpath for first e-packages because of all tried methods this was
easiest and did work. I use it in all e-packages for consistency now. May change
method in future, maybe even fix this upstream =)

2. No problem, will fix.
Comment 4 Pavel Shevchuk 2008-05-20 11:06:13 EDT
New Package CVS Request
=======================
Package Name: ecore
Short Description: Event/X abstraction layer
Owners: stalwart
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
Comment 5 Pavel Shevchuk 2008-05-20 11:07:15 EDT
Ouch, misclicked =\
Real request:


New Package CVS Request
=======================
Package Name: emotion
Short Description: An Evas smart-object library providing video capabilities
Owners: stalwart
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-05-20 12:10:44 EDT
cvs done.
Comment 7 Pavel Shevchuk 2008-05-20 16:24:32 EDT
Koji completed building imported pkg, description fixed after Rex's suggestion. 
Thanks Rex and Kevin!

Note You need to log in before you can comment on or make changes to this bug.