Bug 452458
| Summary: | Review Request: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nigel Jones <dev> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, msuchy, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.03-12.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-06-27 19:34:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 452450 | ||
|
Description
Nigel Jones
2008-06-23 04:05:19 UTC
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675955 + rpmlint is silent for SRPM But NOT for RPM. perl-Crypt-GeneratePassword.noarch: W: file-not-utf8 /usr/share/doc/perl-Crypt-GeneratePassword-0.03/README The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> You can use iconv to fix this. + source files match upstream url 65a9e924ba7496ebd13b70d863d8ae1b Crypt-GeneratePassword-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test is ok. + Package perl-Crypt-GeneratePassword-0.03-12.fc10 => Provides: perl(Crypt::GeneratePassword) = 0.03 Requires: perl(:MODULE_COMPAT_5.10.0) perl(Exporter) perl(strict) perl(vars) SHOULD: * Use iconv to fix rpmlint warning before importing this package to CVS. APPROVED. (In reply to comment #1) > + rpmlint is silent for SRPM But NOT for RPM. > perl-Crypt-GeneratePassword.noarch: W: file-not-utf8 > /usr/share/doc/perl-Crypt-GeneratePassword-0.03/README > The character encoding of this file is not UTF-8. Consider converting it > in the specfile for example using iconv(1). > ==> You can use iconv to fix this. Will do. > APPROVED. New Package CVS Request ======================= Package Name: perl-Crypt-GeneratePassword Short Description: Generate secure random pronounceable passwords Owners: nigelj Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes cvs done. perl-Crypt-GeneratePassword-0.03-12.fc9 has been submitted as an update for Fedora 9 perl-Crypt-GeneratePassword-0.03-12.fc8 has been submitted as an update for Fedora 8 perl-Crypt-GeneratePassword-0.03-12.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. perl-Crypt-GeneratePassword-0.03-12.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. perl-Crypt-GeneratePassword-0.03-12.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 466879 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: perl-Crypt-GeneratePassword New Branches: epel7 Owners: msuchy Git done (by process-git-requests). |