Bug 454022

BuildRequires: desktop-file-utils

New Spec: http://auroralinux.org/people/spot/review/coccinella/coccinella.spec
New SRPM: http://auroralinux.org/people/spot/review/coccinella/coccinella-0.96.10-1.fc10.src.rpm

I built this and the various packages missing from fedora on a fedora 9ish system. Running coccinella I'm getting this:

thirsty:~$ DISPLAY=:0.0 coccinella
Error in startup script: version conflict for package "xml": have 3.1, need 99.0
    while executing
"package require xml 99.0"
    (file "/usr/share/coccinella/jabberlib/wrapper.tcl" line 74)
    invoked from within
"source /usr/share/coccinella/jabberlib/wrapper.tcl"
    ("package ifneeded wrapper 1.2" script)
    invoked from within
"package require wrapper"
    (file "/usr/share/coccinella/jabberlib/jabberlib.tcl" line 147)
    invoked from within
"source /usr/share/coccinella/jabberlib/jabberlib.tcl"
    ("package ifneeded jlib 2.0" script)
    invoked from within
"package require jlib"
    (file "/usr/share/coccinella/jabber/Jabber.tcl" line 31)
    invoked from within
"source /usr/share/coccinella/jabber/Jabber.tcl"
    ("package ifneeded Jabber 1.0" script)
    invoked from within
"package require Jabber"
    (file "/usr/bin/coccinella" line 260)


My builds are here:
http://freeeee.org/source/ http://freeeee.org/i386/

Yep, I missed something. Fixed in -2:

New SRPM: http://www.auroralinux.org/people/spot/review/coccinella/coccinella-0.96.10-2.fc10.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/coccinella/coccinella.spec

It's segfaulting on me. Right after "Set and read preferences" in the splash screen. Here's the end of the strace, if that helps at all:

5141  lstat64("/usr", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
5141  lstat64("/usr/share", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
5141  lstat64("/usr/share/coccinella", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
5141  lstat64("/usr/share/coccinella/iconsets", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
5141  lstat64("/usr/share/coccinella/iconsets/emoticons", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
5141  lstat64("/usr/share/coccinella/iconsets/emoticons/default", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
5141  open("/usr/share/coccinella/iconsets/emoticons/default/face-smile.png", O_RDONLY|O_LARGEFILE) = 4
5141  fcntl64(4, F_SETFD, FD_CLOEXEC)   = 0
5141  ioctl(4, SNDCTL_TMR_TIMEBASE or TCGETS, 0xbfe77d68) = -1 ENOTTY (Inappropriate ioctl for device)
5141  _llseek(4, 0, [0], SEEK_SET)      = 0
5141  read(4, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0\26\0\0\0\26\20\6\0\0\0\224$\260"..., 4096) = 2609
5141  _llseek(4, 0, [0], SEEK_SET)      = 0
5141  --- SIGSEGV (Segmentation fault) @ 0 (0) ---
5141  +++ killed by SIGSEGV +++



---> ioctl(4, SNDCTL_TMR_TIMEBASE or TCGETS, 0xbfe77d68) = -1 ENOTTY (Inappropriate ioctl for device)

I fixed a bug in tkimg recently that was causing behavior like this, but I think I only did it for rawhide. Can you try updating to:

http://koji.fedoraproject.org/koji/buildinfo?buildID=66555

If that resolves it, I'll do proper F-8/F-9 builds.

It at least launches ok now. I haven't tested further, but will try sometime this week.

New SRPM: http://www.auroralinux.org/people/spot/review/new/coccinella-0.96.10-3.fc11.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/coccinella.spec

spot, could you update to the latest version, so I can do the review?

Whoops. Here's the latest:

New SRPM:
http://www.auroralinux.org/people/spot/review/new/coccinella-0.96.12-1.fc11.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/new/coccinella.spec

OK. Here's my review. There are some issues but most of them are very trivial.

* The new guidelines prefer usage of %global instead of %define. But I don't think these lines are needed by this package anyways:
   %{!?tcl_version: %define tcl_version %(echo 'puts $tcl_version' | tclsh)}
   %{!?tcl_sitearch: %define tcl_sitearch %{_libdir}/tcl%{tcl_version}}
They are not used.

- the rpmlint "coccinella.noarch: E: explicit-lib-dependency tcl-zlib" can be ignored since this package really needs this explicit dependency.

* Group: System Environment/Libraries
is wrong. Should this be Applications/Internet ?

* I believe that AUTHORS.txt should go to %doc.

? Should docs/ really go to %doc? I don't know what those files are for.

* There are many files under contrib/ directory that are marked BSD and they end up in the final package. Hence, the package is GPLv3 and BSD.

* rpm -qplv coccinella-0.96.12-1.fc11.noarch.rpm |grep -- "-rwxr-xr-x"
shows a large amount of png, wav, ico and gif files with wrong executable permissions. I wonder why rpmlint doesn't complain.

* Please swap the occurrence of $RPM_BUILD_ROOT with %{buildroot} for macro consistency.

! desktop-file-validate on the .desktop file complains:
   coccinella.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

! Also please add a Comment=something to the .desktop file to please the gnome users.

! You can use themes/Oxygen/icons/128x128/coccinella.png as the application pixmap for better quality.

? About the software: 
   - Info->Update Check shows wrong version. No big deal though.
   - Info->About Coccinella says "Looking for Img..." but it did not find it yet on my computer. No biggie either.

All of the packaging issues are resolved in -2:

Updated SRPM: http://www.auroralinux.org/people/spot/review/new/coccinella-0.96.12-2.fc11.src.rpm
Updated SPEC: http://www.auroralinux.org/people/spot/review/new/coccinella.spec

Great

---------------------------------------------
This package (coccinella) is APPROVED by oget
---------------------------------------------

New Package CVS Request
=======================
Package Name: coccinella
Short Description: Chat client with whiteboard
Owners: spot
Branches: F-9 F-10 devel
InitialCC: 

...and it's done.

coccinella-0.96.12-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/coccinella-0.96.12-2.fc9

coccinella-0.96.12-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/coccinella-0.96.12-2.fc10

coccinella-0.96.12-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

coccinella-0.96.12-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.