Bug 455757
Summary: | Review Request: pyexiv2 - Python binding to exiv2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> |
Component: | Package Review | Assignee: | Dan Horák <dan> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mcepl, notting |
Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-07-18 22:19:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matěj Cepl
2008-07-17 16:14:40 UTC
Builds in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=722738 OK* source files match upstream: 6ae7aa7e155117ea2356e78112ede2031fc06c8e pyexiv2-0.1.2.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. BAD license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. BAD compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). BAD debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - use full URL to the source archive - license tag should be GPLv2+ - package's own compile flags are used (see http://dev.gentoo.org/~vapier/scons-blows.txt) - debuginfo doesn't contain source files - depends on the right flags SPEC file is in the same URL, and updated. SRPM is http://mcepl.fedorapeople.org/rpms/pyexiv2-0.1.2-2.fc9.src.rpm Thanks, Dan, for the help. Matěj, you forgot to use the full URL for the source archive (http://tilloy.net/dev/pyexiv2/releases/pyexiv2-0.1.2.tar.bz2). This package is APPROVED when the Source0 tag is updated. New Package CVS Request ======================= Package Name: pyexiv2 Short Description: Python binding to exiv2 Owners:mcepl Branches: F-8 F-9 InitialCC: Cvsextras Commits:yes cvs done. |